On Tue, Aug 11, 2026 at 11:24:54AM +0200, Denis V. Lunev via Devel wrote: > Where QEMU_CAPS_WIN_DMP_GUEST_AWARE is present, QEMU reports win-dmp > as available only for a guest that has published a vmcoreinfo dump > header. In that case prefer it over the elf default: converting an > elf dump into a Windows-debuggable format afterwards is possible but > complicated and unreliable. > > Add qemuDomainGetAutoDumpFormat(), which probes win-dmp support > right before an auto-triggered dump and falls back to elf > otherwise. Use it from both doCoreDumpToAutoDumpPath() (on_crash) > and processWatchdogEvent() (watchdog dump). virDomainCoreDump() and > virDomainCoreDumpWithFormat() are left untouched, since RAW there > is a documented part of their API contract, standing in for an > explicit caller request rather than an internal default. > > The probe is best-effort: reset any error left by a failed monitor > call or QMP command, so it cannot leak past a dump that otherwise > succeeds. > > Without the capability the probe is skipped: older QEMU offers win-dmp > on any x86 machine, where the resulting dump is useless. > > Signed-off-by: Denis V. Lunev <[email protected]> > --- > NEWS.rst | 7 +++++++ > src/qemu/qemu_driver.c | 33 +++++++++++++++++++++++++++++++-- > 2 files changed, 38 insertions(+), 2 deletions(-)
Reviewed-by: Daniel P. Berrangé <[email protected]> With regards, Daniel -- |: https://berrange.com ~~ https://hachyderm.io/@berrange :| |: https://libvirt.org ~~ https://entangle-photo.org :| |: https://pixelfed.art/berrange ~~ https://fstop138.berrange.com :|
