On 8/26/26 10:46, [email protected] wrote:
> From: shotor <[email protected]>
> 
> Check VIR_DOMAIN_DEFINE_VALIDATE instead of VIR_DOMAIN_START_VALIDATE
> when deciding whether to enable schema validation.
> VIR_DOMAIN_START_VALIDATE is not a valid flag for this API and can never
> be true for a valid call.
> 
> Signed-off-by: shotor <[email protected]>
> ---
>  src/ch/ch_driver.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/ch/ch_driver.c b/src/ch/ch_driver.c
> index ff3cb55c69..f85f38eaf2 100644
> --- a/src/ch/ch_driver.c
> +++ b/src/ch/ch_driver.c
> @@ -349,7 +349,7 @@ chDomainDefineXMLFlags(virConnectPtr conn, const char 
> *xml, unsigned int flags)
>  
>      virCheckFlags(VIR_DOMAIN_DEFINE_VALIDATE, NULL);
>  
> -    if (flags & VIR_DOMAIN_START_VALIDATE)
> +    if (flags & VIR_DOMAIN_DEFINE_VALIDATE)
>          parse_flags |= VIR_DOMAIN_DEF_PARSE_VALIDATE_SCHEMA;
>  
>      /* Avoid parsing the whole domain definition for ACL checks */

Reviewed-by: Michal Privoznik <[email protected]>

and merged.

Michal

Reply via email to