>-----Original Message-----
>From: Peter Krempa <[email protected]>
>Subject: Re: [PATCH v2 03/12] qemu: format scalable-mode on intel-iommu
>command line
>
>On Wed, Sep 09, 2026 at 16:29:50 +0800, Zhenzhong Duan wrote:
>> Add scalable-mode attribute to qemu command line if specified in
>> domain conf.
>>
>> Signed-off-by: Zhenzhong Duan <[email protected]>
>> ---
>>  src/qemu/qemu_command.c                                         | 1 +
>>  .../intel-iommu-scalable-mode.x86_64-latest.args                | 2 +-
>>  2 files changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
>> index bcddb9c922..d7afdb4ee4 100644
>> --- a/src/qemu/qemu_command.c
>> +++ b/src/qemu/qemu_command.c
>> @@ -6343,6 +6343,7 @@ qemuBuildIOMMUCommandLine(virCommand *cmd,
>>                                        "T:device-iotlb", iommu->iotlb,
>>                                        "p:aw-bits", iommu->aw_bits,
>>                                        "T:dma-translation", 
>> iommu->dma_translation,
>> +                                      "T:scalable-mode", 
>> iommu->scalable_mode,
>>                                        NULL) < 0)
>>                  return -1;
>>
>> diff --git a/tests/qemuxmlconfdata/intel-iommu-scalable-mode.x86_64-
>latest.args b/tests/qemuxmlconfdata/intel-iommu-scalable-mode.x86_64-
>latest.args
>> index c12d76bd89..bda776f46a 100644
>> --- a/tests/qemuxmlconfdata/intel-iommu-scalable-mode.x86_64-latest.args
>> +++ b/tests/qemuxmlconfdata/intel-iommu-scalable-mode.x86_64-latest.args
>> @@ -26,7 +26,7 @@ XDG_CONFIG_HOME=/var/lib/libvirt/qemu/domain--1-
>QEMUGuest1/.config \
>>  -rtc base=utc \
>>  -no-shutdown \
>>  -boot strict=on \
>> --device '{"driver":"intel-iommu","id":"iommu0"}' \
>> +-device '{"driver":"intel-iommu","id":"iommu0","scalable-mode":true}' \
>>  -audiodev '{"id":"audio1","driver":"none"}' \
>>  -global ICH9-LPC.noreboot=off \
>>  -watchdog-action reset \
>
>Since all code is already added in the patch that adds the 'conf' bits,
>I don't think this needs to be separate.

Got it, will merge each qemu cmdline patch into their 'conf' patch.

Thanks
Zhenzhong

Reply via email to