On 9/21/26 12:40, Davide Marro via Devel wrote:
> From: Davide Marro <[email protected]>
> 
> QEMU uses uint64 values for block latency histogram boundaries, while
> libvirt currently stores and parses them as unsigned int values.
> 
> This limits histogram boundaries to UINT32_MAX nanoseconds and prevents
> using larger values supported by QEMU.
> 
> Use unsigned long long for latency histogram boundaries throughout the
> domain configuration and QEMU monitor code. Update the XML schema and
> parser accordingly, and serialize the values using the 64-bit JSON
> number helper.
> 
> Extend the XML and QEMU monitor tests with a 5000000000 nanosecond
> boundary to verify values above UINT32_MAX are preserved.
> 
> Resolves: https://gitlab.com/libvirt/libvirt/-/work_items/919
> 
> Signed-off-by: Davide Marro <[email protected]>
> ---
>  src/conf/domain_conf.c                        | 12 ++---
>  src/conf/domain_conf.h                        | 10 ++--
>  src/conf/schemas/domaincommon.rng             |  2 +-
>  src/qemu/qemu_monitor.c                       | 10 ++--
>  src/qemu/qemu_monitor.h                       | 10 ++--
>  src/qemu/qemu_monitor_json.c                  | 14 +++---
>  src/qemu/qemu_monitor_json.h                  | 10 ++--
>  tests/qemumonitorjsontest.c                   | 46 ++++++++++++++++---
>  ...isk-statistics-intervals.x86_64-latest.xml |  1 +
>  .../disk-statistics-intervals.xml             |  1 +
>  10 files changed, 75 insertions(+), 41 deletions(-)

Reviewed-by: Michal Privoznik <[email protected]>

and merged. Congratulations on your first libvirt contribution!

Michal

Reply via email to