On 9/23/26 18:04, Roman Bogorodskiy wrote:
> Bhyve supports specifying boot order for SATA and Virtio disk devices
> using the 'bootindex=' option. Update the command building code to use
> this argument when <boot order='..'/> is specified in the domain XML.
> 
> Reject boot indexes that exceed the signed integer range accepted by
> bhyve.
> 
> Signed-off-by: Roman Bogorodskiy <[email protected]>
> ---
>  src/bhyve/bhyve_command.c                     | 12 +++++--
>  src/bhyve/bhyve_domain.c                      |  9 +++++
>  .../bhyvexml2argv-bhyveload-bootorder3.args   |  2 +-
>  .../bhyvexml2argv-bootorder-invalid-index.xml | 17 ++++++++++
>  .../x86_64/bhyvexml2argv-bootorder.args       | 13 +++++++
>  .../x86_64/bhyvexml2argv-bootorder.ldargs     |  1 +
>  .../x86_64/bhyvexml2argv-bootorder.xml        | 34 +++++++++++++++++++
>  .../x86_64/bhyvexml2argv-grub-bootorder.args  |  2 +-
>  .../x86_64/bhyvexml2argv-grub-bootorder2.args |  2 +-
>  tests/bhyvexml2argvtest.c                     |  2 ++
>  10 files changed, 89 insertions(+), 5 deletions(-)
>  create mode 100644 
> tests/bhyvexml2argvdata/x86_64/bhyvexml2argv-bootorder-invalid-index.xml
>  create mode 100644 
> tests/bhyvexml2argvdata/x86_64/bhyvexml2argv-bootorder.args
>  create mode 100644 
> tests/bhyvexml2argvdata/x86_64/bhyvexml2argv-bootorder.ldargs
>  create mode 100644 tests/bhyvexml2argvdata/x86_64/bhyvexml2argv-bootorder.xml

For both:

Reviewed-by: Michal Privoznik <[email protected]>

Michal

Reply via email to