Thanks for the review Michal! Before pushing, I'd like to get opinions on an
idea Claudio and I discussed off-list: a new VIR_DOMAIN_EVENT_UNDEFINED_MIGRATED
detail for the UNDEFINED event.
On 10/14/26 7:26 AM, Michal Prívozník wrote:
On 10/13/26 22:47, Jim Fehlig via Devel wrote:
From: Jim Fehlig <[email protected]>
When migrating with VIR_MIGRATE_UNDEFINE_SOURCE, qemuMigrationSrcConfirm()
and qemuMigrationSrcPerformJob() delete the domain's persistent config on
the source host but never emit a VIR_DOMAIN_EVENT_UNDEFINED lifecycle
event. Applications relying solely on domain events never learn the domain
was undefined on the source. Emit the event, reusing the existing
VIR_DOMAIN_EVENT_UNDEFINED_REMOVED detail since the semantics match
virDomainUndefine().
While the semantics are the same within libvirt (virDomainDeleteConfig;
vm->persistent=0;), the distinction between UNDEFINED_REMOVED and
UNDEFINED_MIGRATED could be important to a platform using libvirt events for
state synchronization. If agreed, I'll respin a V2 adding the new detail.
Regards,
Jim
Signed-off-by: Jim Fehlig <[email protected]>
---
src/qemu/qemu_migration.c | 10 ++++++++++
1 file changed, 10 insertions(+)
Reviewed-by: Michal Privoznik <[email protected]>
Michal
