On Thu, Oct 15, 2026 at 01:57:05PM +0200, Michal Prívozník wrote: > On 10/12/26 13:20, Magnus Kulke wrote: > I see where you're coming from, but this is not the correct test. This > should be another test case (or an existing one modified) to > qemuxmlconftest. There, mocking is used, i.e. there's an alternative > implementation of qemuInterfaceOpenVhostNet() that's used from the test > binary. Unfortunately, the alternative implementation does not honor the > check from 1/2. >
> We have two options here: > > 1) I'll merge just your first patch, or > 2) I'll post patches to make test suite have the same check as the > production code, and you'll rebase your patches on top. > thanks for the review. yes, I figured that there was a proper place to add the test, but I didn't find it at first glance. I'm fine with dropping the test commit and merging 1/2 (i.e. option 1). If I should add a test case later once qemuxmlconftest is able to cover it, you can cc me. best, magnus
