Hi Michael,

On 03/19/2012 11:19 PM, Michael Walle wrote:
+       custom_divisor = 0;
+       switch(baud) {
+       case 9600: c_cflag = B9600; break;
+       case 19200: c_cflag = B19200; break;

Just nitpicking here - the rest of the code indents the inside of the switch.

                printf("[FLTERM] baudrate not supported\n");

Better send that to stderr.

+                       case OPTION_SPEED:
+                               baud = strtoul(optarg,&endptr, 0);
+                               if(*endptr != 0) baud = 115200;

Yeah, better print an error message here. Otherwise looks great, thanks! You can send me an updated patch for commit.

Best,
Sébastien
_______________________________________________
http://lists.milkymist.org/listinfo.cgi/devel-milkymist.org
IRC: #milkymist@Freenode

Reply via email to