Re: [OMPI devel] openmpi-1.2.4 compilation error in orte_abort.c on Fedora 8 - patch included

[George Bosilca]

0600 you means ? I don't really see why you want to share the file with the whole group ?

  Thanks,
    george.

On Dec 10, 2007, at 5:15 PM, Ralph Castain wrote:

Nah, go ahead! Just change the permission to 0660 - that's a private file

that others shouldn't really perturb.

Ralph



On 12/10/07 2:59 PM, "Jeff Squyres" <jsquy...@cisco.com> wrote:

Yo Ralph --


me committing to trunk/v1.2?

(Thanks Sebastian -- stupid Fedora! ;-) )


On Dec 10, 2007, at 11:02 AM, Sebastian Schmitzdorff wrote:

I see you committed this to the ORTE-future branch. Any objections to

Hi,

on Fedora 8 x86_64 openmpi-1.2.4 doesn't compile.
A quick glance at the nightly openmpi snapshot leads me to the
conclusion that
this is still the case.

----------------------------------------------------
In function 'open',
 inlined from 'orte_abort' at runtime/orte_abort.c:91:
/usr/include/bits/fcntl2.h:51: error: call to '__open_missing_mode'
declared with attribute error: open with O_CREAT in second argument
needs 3 arguments
make[1]: *** [runtime/orte_abort.lo] Error 1

orte'
make: *** [all-recursive] Error 1
----------------------------------------------------

There is a missing filemode in "open" in orte_abort.c:91.
fcntl2.h doesnt allow this anymore.

please find the simple diff below.

--------------------------------------------
--- runtime/orte_abort.c        2007-12-10 00:01:50.000000000 +0100
+++ test        2007-12-10 00:01:00.000000000 +0100
@@ -88,7 +88,7 @@
          ORTE_ERROR_LOG(ORTE_ERR_OUT_OF_RESOURCE);
          goto CLEANUP;
      }
-        fd = open(abort_file, O_CREAT);
+        fd = open(abort_file, O_CREAT, 0666);
      if (0 < fd) close(fd);
  }
--------------------------------------------

Hope this is the right place for the diff.

regards
sebastian

--

Sebastian Schmitzdorff - Managing Director
Hamburgnet
http://www.hamburgnet.de
Kottwitzstrasse 49 D-20253 Hamburg
fon: +49 40 736 72-322 fax: +49 40 736 72-321

_______________________________________________
devel mailing list
de...@open-mpi.org
http://www.open-mpi.org/mailman/listinfo.cgi/devel

make[1]: Leaving directory `/var/tmp/OFED_topdir/BUILD/ openmpi-1.2.4/

_______________________________________________
devel mailing list
de...@open-mpi.org
http://www.open-mpi.org/mailman/listinfo.cgi/devel

smime.p7s
Description: S/MIME cryptographic signature