Yo Rainer

This generated a bunch of warnings - the "z" length modifier is not a generally supported option, which is why we do not use it.

btl_tcp_frag.c: In function ‘mca_btl_tcp_frag_send’:
btl_tcp_frag.c:115: warning: ISO C90 does not support the ‘z’ printf length modifier btl_tcp_frag.c:115: warning: ISO C90 does not support the ‘z’ printf length modifier
btl_tcp_frag.c: In function ‘mca_btl_tcp_frag_recv’:
btl_tcp_frag.c:207: warning: ISO C90 does not support the ‘z’ printf length modifier btl_tcp_frag.c:207: warning: ISO C90 does not support the ‘z’ printf length modifier
btl_tcp_component.c: In function ‘mca_btl_tcp_component_create_listen’:
btl_tcp_component.c:682: warning: too many arguments for format
btl_tcp_proc.c: In function ‘mca_btl_tcp_proc_create’:
btl_tcp_proc.c:134: warning: ISO C90 does not support the ‘z’ printf length modifier

Could you please fix this? If you want to deal with the size_t 32/64 bit issues, there is another little macro thingy that we created for just that purpose (someone else here undoubtedly remembers it).

Thanks
Ralph


On May 13, 2009, at 6:52 PM, rusra...@osl.iu.edu wrote:

Author: rusraink
Date: 2009-05-13 20:52:20 EDT (Wed, 13 May 2009)
New Revision: 21234
URL: https://svn.open-mpi.org/trac/ompi/changeset/21234

Log:
- Use the "z" length modifier for size_t arguments for printf.


Text files modified:
  trunk/ompi/mca/btl/tcp/btl_tcp_frag.c |     4 ++--
  trunk/ompi/mca/btl/tcp/btl_tcp_proc.c |     2 +-
  2 files changed, 3 insertions(+), 3 deletions(-)

Modified: trunk/ompi/mca/btl/tcp/btl_tcp_frag.c
= = = = = = = = ======================================================================
--- trunk/ompi/mca/btl/tcp/btl_tcp_frag.c       (original)
+++ trunk/ompi/mca/btl/tcp/btl_tcp_frag.c 2009-05-13 20:52:20 EDT (Wed, 13 May 2009)
@@ -112,7 +112,7 @@
            case EWOULDBLOCK:
                return false;
            case EFAULT:
- BTL_ERROR(("mca_btl_tcp_frag_send: writev error (%p, %d)\n\t%s(%d)\n", + BTL_ERROR(("mca_btl_tcp_frag_send: writev error (%p, %zd)\n\t%s(%zd)\n", frag->iov_ptr[0].iov_base, frag- >iov_ptr[0].iov_len,
                    strerror(opal_socket_errno), frag->iov_cnt));
                mca_btl_tcp_endpoint_close(frag->endpoint);
@@ -204,7 +204,7 @@
        case EWOULDBLOCK:
            return false;
        case EFAULT:
- BTL_ERROR(("mca_btl_tcp_frag_recv: readv error (%p, %d) \n\t%s(%d)\n", + BTL_ERROR(("mca_btl_tcp_frag_recv: readv error (%p, %zd) \n\t%s(%zd)\n", frag->iov_ptr[0].iov_base, frag- >iov_ptr[0].iov_len,
                       strerror(opal_socket_errno), frag->iov_cnt));
            mca_btl_tcp_endpoint_close(btl_endpoint);

Modified: trunk/ompi/mca/btl/tcp/btl_tcp_proc.c
= = = = = = = = ======================================================================
--- trunk/ompi/mca/btl/tcp/btl_tcp_proc.c       (original)
+++ trunk/ompi/mca/btl/tcp/btl_tcp_proc.c 2009-05-13 20:52:20 EDT (Wed, 13 May 2009)
@@ -131,7 +131,7 @@
        return NULL;
    }
    if(0 != (size % sizeof(mca_btl_tcp_addr_t))) {
- BTL_ERROR(("mca_base_modex_recv: invalid size %d: btl-size: %d\n", + BTL_ERROR(("mca_base_modex_recv: invalid size %zd: btl- size: %ld\n",
          size, sizeof(mca_btl_tcp_addr_t)));
        return NULL;
    }
_______________________________________________
svn mailing list
s...@open-mpi.org
http://www.open-mpi.org/mailman/listinfo.cgi/svn


Reply via email to