On Thu, 6 Aug 2009, Jeff Squyres wrote:

>  -Source: openmpi-%{version}.tar.$EXTENSION
>  +Source: %{name}-%{version}.tar.$EXTENSION

The spec file parser defines some of these variables by default. F.e. after encountering at the top of the file:

Name: fftw
Version: 2.1.5
Release: 5.bc

something like %{name}-%{version}-%{release} will be expanded to fftw-2.1.5-5.bc. So there is no need to define any of these variables... The suggestion for improvement here is only cosmetic, it looks nicer to not have hardcoded names all over the spec file. This makes it easier to later change the name of the package, f.e. to allow installing several packages at the same time by simply changing:

Name: fftw2

to allow for the package called 'fftw' to track the 3.x versions. This was done previously by Red Hat f.e. for their python packages.

--
Bogdan Costescu

IWR, University of Heidelberg, INF 368, D-69120 Heidelberg, Germany
Phone: +49 6221 54 8240, Fax: +49 6221 54 8850
E-mail: bogdan.coste...@iwr.uni-heidelberg.de

Reply via email to