Re: [OMPI devel] [OMPI svn] svn:open-mpi r22014

[Ralph Castain]

The issue isn't why or why not static, Jeff - the issue is that we get  
a compiler warning whenever we do a developer build.

On Sep 29, 2009, at 2:32 PM, Jeff Squyres wrote:
I don't think we need to DECLSPEC it, do we?  We don't need (or  
want) this symbol to be visible at the link level when user apps  
link against libmpi.  You might want to put in a comment about why  
it's not static so that we don't repeat this conversation again next  
year.  ;-)

I think not having it DECLSPEC'ed should still work for the debugger  
(since it worked before when it was static), but if you could test  
it to be sure, that would be great...


On Sep 29, 2009, at 4:03 PM, Ethan Mallove wrote:

On Mon, Sep/28/2009 03:11:46PM, Ethan Mallove wrote:
> On Mon, Sep/28/2009 02:05:14PM, Jeff Squyres wrote:
> > Try a newer compiler than gcc 3.4 -- it's pretty ancient.
>
> I don't get the warning with 4.1.2 either.

To get the warning I needed to enable some developer configure  
options (e.g.,
mkdir .svn && configure).

The below patch gets rid of the warning, but is it the right way?

--- ompi/debuggers/debuggers.h
+++ ompi/debuggers/debuggers.h
@@ -40,6 +40,11 @@
     */
    OMPI_DECLSPEC void ompi_debugger_notify_abort(char *string);

+    /**
+     * Breakpoint function for parallel debuggers.
+     */
+    OMPI_DECLSPEC void *MPIR_Breakpoint(void);
+
END_C_DECLS

#endif /* OMPI_DEBUGGERS_H */

-Ethan


>
> -Ethan
>
> >
> >
> > On Sep 28, 2009, at 2:03 PM, Ethan Mallove wrote:
> >
> >> On Fri, Sep/25/2009 09:31:51PM, Ralph Castain wrote:
> >> > I think there is a problem with this change - here is a  
warning I get
> >> when
> >> > compiling on Mac and Linux:
> >> >
> >> > ompi_debuggers.c:265: warning: no previous prototype for
> >> ‘MPIR_Breakpoint’
> >> >
> >> > Can you please take a look?
> >>
> >> Can you send me your config.log file? I can't reproduce the  
warning
> >> using GCC (3.4.6) on RHEL 4.
> >>
> >> -Ethan
> >>
> >> >
> >> > Thanks
> >> > Ralph
> >> >
> >> > On Sep 25, 2009, at 1:14 PM, emall...@osl.iu.edu wrote:
> >> >
> >> >> Author: emallove
> >> >> Date: 2009-09-25 15:14:19 EDT (Fri, 25 Sep 2009)
> >> >> New Revision: 22014
> >> >> URL: https://svn.open-mpi.org/trac/ompi/changeset/22014
> >> >>
> >> >> Log:
> >> >> Remove `static` from `MPIR_Breakpoint` so Intel compilers  
will not
> >> inline
> >> >> it
> >> >>
> >> >> Text files modified:
> >> >>   trunk/ompi/debuggers/ompi_debuggers.c |     2 +-
> >> >>   1 files changed, 1 insertions(+), 1 deletions(-)
> >> >>
> >> >> Modified: trunk/ompi/debuggers/ompi_debuggers.c
> >> >>
> >>  
= 
= 
= 
= 
= 
= 
= 
= 
= 
=====================================================================
> >> >> --- trunk/ompi/debuggers/ompi_debuggers.c    (original)
> >> >> +++ trunk/ompi/debuggers/ompi_debuggers.c    2009-09-25  
15:14:19 EDT
> >> (Fri, 25
> >> >> Sep 2009)
> >> >> @@ -261,7 +261,7 @@
> >> >>  * defined in orterun for the starter.  It should never  
conflict with
> >> >>  * this one, but we'll make it static, just to be sure.
> >> >>  */
> >> >> -static void *MPIR_Breakpoint(void)
> >> >> +void *MPIR_Breakpoint(void)
> >> >> {
> >> >>     return NULL;
> >> >> }
> >> >> _______________________________________________
> >> >> svn mailing list
> >> >> s...@open-mpi.org
> >> >> http://www.open-mpi.org/mailman/listinfo.cgi/svn
> >> >
> >> >
> >> > _______________________________________________
> >> > devel mailing list
> >> > de...@open-mpi.org
> >> > http://www.open-mpi.org/mailman/listinfo.cgi/devel
> >>
> >> <ATT20809437.txt>
> >
> >
> > --
> > Jeff Squyres
> > jsquy...@cisco.com
> >
> >
> > _______________________________________________
> > devel mailing list
> > de...@open-mpi.org
> > http://www.open-mpi.org/mailman/listinfo.cgi/devel

<ATT21059370.txt>


--
Jeff Squyres
jsquy...@cisco.com


_______________________________________________
devel mailing list
de...@open-mpi.org
http://www.open-mpi.org/mailman/listinfo.cgi/devel