The change was to add casting:
} while (!OPAL_ATOMIC_CMPSET_32((int32_t*)&ep->eager_rdma_remote.seq,
(int32_t)ftr->seq,
(int32_t)ftr->seq+1));
Is it safe to simply cast a (uint32_t*) to (int32_t*) in the first param?
Also, it seems like the 3rd parameter could be problematic if it ever goes
larger than 2B -- it'll increment in the wrong direction, won't it?
On Jul 20, 2010, at 3:23 AM, Christopher Yeoh wrote:
> Hi Jeff,
>
> I've committed a fix for this in r23441
>
> Regards,
>
> Chris
>
> On Mon, 19 Jul 2010 11:58:31 -0400
> Jeff Squyres <jsquy...@cisco.com> wrote:
>
> > Chris Yeoh --
> >
> > SVN blame says that this is your line of code. Can you fix?
> >
> >
> > On Jul 17, 2010, at 12:27 PM, Ralph Castain wrote:
> >
> > > Yo IB-folks
> > >
> > > Are we ever going to get these warnings corrected? This is from
> > > current trunk, built on a Linux system --with-openib. It has been
> > > this way for quite some time...
> > >
> > > In file included from btl_openib_proc.h:27,
> > > from btl_openib.c:50:
> > > btl_openib_endpoint.h: In function ‘post_send’:
> > > btl_openib_endpoint.h:506: warning: pointer targets in passing
> > > argument 1 of ‘opal_atomic_cmpset_32’ differ in signedness In file
> > > included from btl_openib_component.c:82: btl_openib_endpoint.h: In
> > > function ‘post_send’: btl_openib_endpoint.h:506: warning: pointer
> > > targets in passing argument 1 of ‘opal_atomic_cmpset_32’ differ in
> > > signedness In file included from btl_openib_endpoint.c:46:
> > > btl_openib_endpoint.h: In function ‘post_send’:
> > > btl_openib_endpoint.h:506: warning: pointer targets in passing
> > > argument 1 of ‘opal_atomic_cmpset_32’ differ in signedness In file
> > > included from btl_openib_proc.h:27, from btl_openib_proc.c:28:
> > > btl_openib_endpoint.h: In function ‘post_send’:
> > > btl_openib_endpoint.h:506: warning: pointer targets in passing
> > > argument 1 of ‘opal_atomic_cmpset_32’ differ in signedness In file
> > > included from btl_openib_async.h:14, from btl_openib_async.c:28:
> > > btl_openib_endpoint.h: In function ‘post_send’:
> > > btl_openib_endpoint.h:506: warning: pointer targets in passing
> > > argument 1 of ‘opal_atomic_cmpset_32’ differ in signedness In file
> > > included from btl_openib_xrc.h:15, from btl_openib_xrc.c:23:
> > > btl_openib_endpoint.h: In function ‘post_send’:
> > > btl_openib_endpoint.h:506: warning: pointer targets in passing
> > > argument 1 of ‘opal_atomic_cmpset_32’ differ in signedness In file
> > > included from btl_openib_ip.c:29: btl_openib_endpoint.h: In
> > > function ‘post_send’: btl_openib_endpoint.h:506: warning: pointer
> > > targets in passing argument 1 of ‘opal_atomic_cmpset_32’ differ in
> > > signedness In file included from ./btl_openib_proc.h:27, from
> > > connect/btl_openib_connect_base.c:14: ./btl_openib_endpoint.h: In
> > > function ‘post_send’: ./btl_openib_endpoint.h:506: warning: pointer
> > > targets in passing argument 1 of ‘opal_atomic_cmpset_32’ differ in
> > > signedness In file included from
> > > connect/btl_openib_connect_oob.c:42: ./btl_openib_endpoint.h: In
> > > function ‘post_send’: ./btl_openib_endpoint.h:506: warning: pointer
> > > targets in passing argument 1 of ‘opal_atomic_cmpset_32’ differ in
> > > signedness In file included from
> > > connect/btl_openib_connect_empty.c:14: ./btl_openib_endpoint.h: In
> > > function ‘post_send’: ./btl_openib_endpoint.h:506: warning: pointer
> > > targets in passing argument 1 of ‘opal_atomic_cmpset_32’ differ in
> > > signedness In file included from
> > > connect/btl_openib_connect_xoob.c:28: ./btl_openib_endpoint.h: In
> > > function ‘post_send’: ./btl_openib_endpoint.h:506: warning: pointer
> > > targets in passing argument 1 of ‘opal_atomic_cmpset_32’ differ in
> > > signedness In file included from ./btl_openib_proc.h:27, from
> > > connect/btl_openib_connect_rdmacm.c:53: ./btl_openib_endpoint.h: In
> > > function ‘post_send’: ./btl_openib_endpoint.h:506: warning: pointer
> > > targets in passing argument 1 of ‘opal_atomic_cmpset_32’ differ in
> > > signedness
> > >
> > >
> > >
> > > _______________________________________________
> > > devel mailing list
> > > de...@open-mpi.org
> > > http://www.open-mpi.org/mailman/listinfo.cgi/devel
> >
> >
>
>
>
>
> --
> cy...@ozlabs.org
>
> _______________________________________________
> devel mailing list
> de...@open-mpi.org
> http://www.open-mpi.org/mailman/listinfo.cgi/devel
>
--
Jeff Squyres
jsquy...@cisco.com
For corporate legal information go to:
http://www.cisco.com/web/about/doing_business/legal/cri/
