Looks ok to me. Go ahead and commit to trunk and file a v1.5 CMR; you can say
I reviewed it.
On Feb 8, 2011, at 5:52 AM, Damien Guinier wrote:
> hi all
>
> On v1.5 branch, can we add MPI_ROOT variable on:
> /%{shell_scripts_path}/%{shell_scripts_basename}.sh
> and /%{shell_scripts_path}/%{shell_scripts_basename}.csh
> with the value : MPI_ROOT=%{_prefix}
>
> The variable MPI_ROOT facilitate launch script creation. This variable is
> asked by customer who use BPS and LSF batch manager.
>
> thanks
>
> Damien Guinier
>
> -------------
>
> diff -r 486ca4bfca95 contrib/dist/linux/openmpi.spec
> --- a/contrib/dist/linux/openmpi.spec Mon Feb 07 15:40:31 2011 +0100
> +++ b/contrib/dist/linux/openmpi.spec Tue Feb 08 14:30:01 2011 +0100
> @@ -514,6 +514,10 @@
> MANPATH=%{_mandir}:\${MANPATH}
> export MANPATH
> fi
> +
> +# MPI_ROOT
> +MPI_ROOT=%{_prefix}
> +export MPI_ROOT
> EOF
> cat <<EOF >
> $RPM_BUILD_ROOT/%{shell_scripts_path}/%{shell_scripts_basename}.csh
> # NOTE: This is an automatically-generated file! (generated by the
> @@ -542,6 +546,9 @@
> else
> setenv MANPATH %{_mandir}:
> endif
> +
> +# MPI_ROOT
> +setenv MPI_ROOT %{_prefix}
> EOF
> %endif
> # End of shell_scripts if
>
> _______________________________________________
> devel mailing list
> [email protected]
> http://www.open-mpi.org/mailman/listinfo.cgi/devel
--
Jeff Squyres
[email protected]
For corporate legal information go to:
http://www.cisco.com/web/about/doing_business/legal/cri/
