Bert: good catch, thanks Mellanox: can you confirm that this change was required?
Sent from my phone. No type good. > On Jul 9, 2014, at 4:59 PM, "Ralph Castain" <r...@open-mpi.org> wrote: > > Ouch - yes, we definitely should roll it to 4:0:0. I gather the ABI change > was required to comply with the spec. I normally would refuse to allow an ABI > change during a stable release series, but have given more latitude to OSHMEM > due to its relatively new inclusion and the need to get it into compliance. > > > >> On Jul 9, 2014, at 1:25 PM, Bert Wesarg <bert.wes...@tu-dresden.de> wrote: >> >> Quoting "Jeff Squyres (jsquyres)" <jsquy...@cisco.com>: >>> Here's what I think VERSION should be for 1.8.2: >>> >>> https://svn.open-mpi.org/trac/ompi/changeset/32165 >>> >>> I left comments in the VERSION file as to why I think each version number >>> should change. >>> >>> Can someone please verify that this work is correct? If so, we can remove >>> the comments (before the final 1.8.2 release). >> >>> -liboshmem_so_version=2:0:1 >>> +liboshmem_so_version=3:0:2 >>> +# lib changed >>> +# added interfaces: shmem_int32_finc, shmem_int64_finc, profiling >> >> I think liboshmem_so_version should get 4:0:0 as the return type of >> shmem_finalize changed from int to void. >> >> Here is the trunk commit: >> >> https://svn.open-mpi.org/trac/ompi/changeset/31413 >> >> And here the CMR commit: >> >> https://svn.open-mpi.org/trac/ompi/changeset/31758 >> >> Regards, >> Bert >> >>> >>> -- >>> Jeff Squyres >> -- >> Dipl.-Inf. Bert Wesarg >> wiss. Mitarbeiter >> >> Technische Universität Dresden >> Zentrum für Informationsdienste und Hochleistungsrechnen (ZIH) >> 01062 Dresden >> Tel.: +49 (351) 463-42451 >> Fax: +49 (351) 463-37773 >> E-Mail: bert.wes...@tu-dresden.de >> >> _______________________________________________ >> devel mailing list >> de...@open-mpi.org >> Subscription: http://www.open-mpi.org/mailman/listinfo.cgi/devel >> Link to this post: >> http://www.open-mpi.org/community/lists/devel/2014/07/15083.php > > _______________________________________________ > devel mailing list > de...@open-mpi.org > Subscription: http://www.open-mpi.org/mailman/listinfo.cgi/devel > Link to this post: > http://www.open-mpi.org/community/lists/devel/2014/07/15084.php
