On Aug 20, 2014, at 11:55 AM, svn-commit-mai...@open-mpi.org wrote: > Author: rhc (Ralph Castain) > Date: 2014-08-20 12:55:36 EDT (Wed, 20 Aug 2014) > New Revision: 32556 > URL: https://svn.open-mpi.org/trac/ompi/changeset/32556 > > Log: > Track down the last piece of the connection problem. It appears that > providing a netmask of 0 to opal_net_samenetwork results in everything > looking like it is on the same network. Hence, we were not retaining any > of the alternative addresses, so we had no other way to check them. > > Refs #4870 > > Text files modified: > trunk/orte/mca/oob/tcp/oob_tcp.c | 8 +++++++- > > trunk/orte/mca/oob/tcp/oob_tcp_connection.c | 1 + > > 2 files changed, 8 insertions(+), 1 deletions(-) > > Modified: trunk/orte/mca/oob/tcp/oob_tcp.c > ============================================================================== > --- trunk/orte/mca/oob/tcp/oob_tcp.c Tue Aug 19 22:48:47 2014 (r32555) > +++ trunk/orte/mca/oob/tcp/oob_tcp.c 2014-08-20 12:55:36 EDT (Wed, 20 Aug > 2014) (r32556) > @@ -282,6 +282,8 @@ > ORTE_NAME_PRINT(ORTE_PROC_MY_NAME)); > > if (AF_INET != pop->af_family) { > + opal_output_verbose(20, orte_oob_base_framework.framework_output, > + "%s NOT AF_INET", > ORTE_NAME_PRINT(ORTE_PROC_MY_NAME)); > goto cleanup; > } > > @@ -306,8 +308,12 @@ > > /* do we already have this address? */ > OPAL_LIST_FOREACH(maddr, &peer->addrs, mca_oob_tcp_addr_t) { > - if (opal_net_samenetwork(&inaddr, (struct sockaddr*)&maddr->addr, > 0)) { > + /* require only that the subnet be the same */ > + if (opal_net_samenetwork(&inaddr, (struct sockaddr*)&maddr->addr, > 24)) {
So... what if I have my hosts on a 10.123.0.0/16 network or some other network with a non-24-bit netmask? -Dave
