Done On Oct 13, 2014, at 2:40 AM, Jeff Squyres (jsquyres) <jsquy...@cisco.com> wrote:
> Good catch. Can you file a pr for the v1.8 branch? You can say I reviewed. > > Sent from my phone. No type good. > >> On Oct 13, 2014, at 4:35 AM, "git...@crest.iu.edu" <git...@crest.iu.edu> >> wrote: >> >> This is an automated email from the git hooks/post-receive script. It was >> generated because a ref change was pushed to the repository containing >> the project "open-mpi/ompi". >> >> The branch, master has been updated >> via 6372ac926c6a6622222915ac4f9301021f731c35 (commit) >> from a215a4831dfae9dd0a3fee7b31ee784d4e5394a4 (commit) >> >> Those revisions listed above that are new to this repository have >> not appeared on any other notification email; so we list those >> revisions in full, below. >> >> - Log ----------------------------------------------------------------- >> https://github.com/open-mpi/ompi/commit/6372ac926c6a6622222915ac4f9301021f731c35 >> >> commit 6372ac926c6a6622222915ac4f9301021f731c35 >> Author: Mike Dubman <mi...@mellanox.com> >> Date: Mon Oct 13 11:33:26 2014 +0300 >> >> tools: fix cli args parsing >> >> No need to "shift" if argument does not expect parameter on the command >> line. >> >> diff --git a/contrib/dist/make_dist_tarball b/contrib/dist/make_dist_tarball >> index de09d26..783709d 100755 >> --- a/contrib/dist/make_dist_tarball >> +++ b/contrib/dist/make_dist_tarball >> @@ -72,7 +72,7 @@ while test "$1" != ""; do >> --no-ompi) want_ompi=0 ;; >> --autogen-args) autogen_args=$2; shift ;; >> --distdir) distdir=$2; shift ;; >> - --dirtyok) dirty_ok=1; shift ;; >> + --dirtyok) dirty_ok=1 ;; >> --verok) gnu_version_ignore=1;; >> --no-git-update) git_update=0;; >> *) >> >> >> ----------------------------------------------------------------------- >> >> Summary of changes: >> contrib/dist/make_dist_tarball | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> >> hooks/post-receive >> -- >> open-mpi/ompi >> _______________________________________________ >> ompi-commits mailing list >> ompi-comm...@open-mpi.org >> http://www.open-mpi.org/mailman/listinfo.cgi/ompi-commits > _______________________________________________ > devel mailing list > de...@open-mpi.org > Subscription: http://www.open-mpi.org/mailman/listinfo.cgi/devel > Link to this post: > http://www.open-mpi.org/community/lists/devel/2014/10/16041.php
