When running "make dist" (several times) today, I noticed the following:

 - WARNING: Got bad config.guess from ftp.gnu.org (non-existent or empty)
 - WARNING: using included versions for both config.sub and config.guess

Nevermind for the moment that the wget is NOT from ftp.gnu.org any longer.
The part that worried me is the "non-existent or empty" claim.

A quick look shows that logic in distscript.csh uses the non-portable "-s"
operator[1].
One should be using "-z" instead of "! -s":

--- a/config/distscript.csh
+++ b/config/distscript.csh
@@ -108,14 +108,14 @@ chmod +x config.guess config.sub
 # unreleased software...

 set happy=0
-if (! -f config.guess || ! -s config.guess) then
+if (! -f config.guess || -z config.guess) then
     echo " - WARNING: Got bad config.guess from ftp.gnu.org (non-existent
or empty)"
 else
     ./config.guess >& /dev/null
     if ($status != 0) then
         echo " - WARNING: Got bad config.guess from ftp.gnu.org (not
executable)"
     else
-        if (! -f config.sub || ! -s config.sub) then
+        if (! -f config.sub || -z config.sub) then
             echo " - WARNING: Got bad config.sub from ftp.gnu.org
(non-existent or empty)"
         else
             ./config.sub `./config.guess` >& /dev/null


-Paul

[1] Two key excerpts from "man 1 tcsh":

 Throughout  this  manual,  features  of  tcsh  not found in most csh(1)
 implementations (specifically, the 4.4BSD csh) are labeled with  `(+)',



 File inquiry operators
  [...]
           z   Zero size
           s   Non-zero size (+)


-- 
Paul H. Hargrove                          phhargr...@lbl.gov
Computer Languages & Systems Software (CLaSS) Group
Computer Science Department               Tel: +1-510-495-2352
Lawrence Berkeley National Laboratory     Fax: +1-510-486-6900

Reply via email to