Ben and Paul,

Thanks for the report !

it looks like a simple typo (e.g. ')' instead of ','

the attached patch is for v1.8
in order to use it, you need recent autotools (see http://www.open-mpi.org/source/building.php)
apply the patch, run autogen.pl, and then configure, make, make install

i am now double checking this

Cheers,

Gilles

On 7/9/2015 11:25 AM, Paul Hargrove wrote:
I just gave the whole 1.8 series a spin and it looks like "ConnectX XRC" configure logic has been broken since 1.8.5, but worked in 1.8.4:

$ grep 'ConnectX XRC support' openmpi-1.*-icc-14/LOG/configure.log| sort -u openmpi-1.8-linux-x86_64-icc-14/LOG/configure.log:checking if ConnectX XRC support is enabled... yes openmpi-1.8.1-linux-x86_64-icc-14/LOG/configure.log:checking if ConnectX XRC support is enabled... yes openmpi-1.8.2-linux-x86_64-icc-14/LOG/configure.log:checking if ConnectX XRC support is enabled... yes openmpi-1.8.3-linux-x86_64-icc-14/LOG/configure.log:checking if ConnectX XRC support is enabled... yes openmpi-1.8.4-linux-x86_64-icc-14/LOG/configure.log:checking if ConnectX XRC support is enabled... yes openmpi-1.8.5-linux-x86_64-icc-14/LOG/configure.log:checking if ConnectX XRC support is enabled... no openmpi-1.8.6-linux-x86_64-icc-14/LOG/configure.log:checking if ConnectX XRC support is enabled... no

In addition to fixing the error in the configure logic, I wonder if anyone has thought on mechanisms to detect regressions of this sort?

-Paul

On Wed, Jul 8, 2015 at 6:11 PM, Ben Menadue <ben.mena...@nci.org.au <mailto:ben.mena...@nci.org.au>> wrote:

    Hi,

    I just finished building 1.8.6 and master on our cluster and
    noticed that
    for both, XRC support wasn't being detected because it didn't
    detect the
    IBV_SRQT_XRC declaration:

            checking whether IBV_SRQT_XRC is declared... (cached) no
            ...
            checking if ConnectX XRC support is enabled... no
            checking if ConnectIB XRC support is enabled... no

    Both of these builds had --enable-openib-connectx-xrc. Having a
    look in the
    config.log, I found this:

    configure:191690: checking whether IBV_SRQT_XRC is declared
    configure:191690: gcc -std=gnu99 -c -O3 -DNDEBUG -finline-functions
    -fno-strict-aliasing -pthread
    -I/short/z00/bjm900/build/openmpi/openmpi-1.8.6/opal/mca/hwloc/hwloc191/hwlo
    c/include
    -I/short/z00/bjm900/build/openmpi/openmpi-1.8.6/build/gnu/opal/mca/hwloc/hwl
    oc191/hwloc/include
    -I/short/z00/bjm900/build/openmpi/openmpi-1.8.6/opal/mca/event/libevent2021/
    libevent
    -I/short/z00/bjm900/build/openmpi/openmpi-1.8.6/opal/mca/event/libevent2021/
    libevent/include
    -I/short/z00/bjm900/build/openmpi/openmpi-1.8.6/build/gnu/opal/mca/event/lib
    event2021/libevent/include  conftest.c >&5
    conftest.c: In function 'main':
    conftest.c:718: error: 'IBV_SRQT_XRC' undeclared (first use in this
    function)
    conftest.c:718: error: (Each undeclared identifier is reported
    only once
    conftest.c:718: error: for each function it appears in.)
    configure:191690: $? = 1

    If you have a look at the test program, the failure is because it
    forgets to
    include the infiniband/verbs.h header, and sure enough the
    configure script
    bears this out:

            ac_fn_c_check_decl "$LINENO" "IBV_SRQT_XRC"
    "ac_cv_have_decl_IBV_SRQT_XRC" "$ac_includes_default"

    Changing "$ac_includes_default" to "#include <infiniband/verbs.h>" and
    reconfiguring allows it to detect this declaration and then enable
    support
    for XRC:

            checking whether IBV_SRQT_XRC is declared... (cached) yes
            ...
            checking if ConnectX XRC support is enabled... yes
            checking if ConnectIB XRC support is enabled... yes

    Cheers,
    Ben


    _______________________________________________
    devel mailing list
    de...@open-mpi.org <mailto:de...@open-mpi.org>
    Subscription: http://www.open-mpi.org/mailman/listinfo.cgi/devel
    Link to this post:
    http://www.open-mpi.org/community/lists/devel/2015/07/17599.php




--
Paul H. Hargrove phhargr...@lbl.gov <mailto:phhargr...@lbl.gov>
Computer Languages & Systems Software (CLaSS) Group
Computer Science Department               Tel: +1-510-495-2352
Lawrence Berkeley National Laboratory     Fax: +1-510-486-6900


_______________________________________________
devel mailing list
de...@open-mpi.org
Subscription: http://www.open-mpi.org/mailman/listinfo.cgi/devel
Link to this post: 
http://www.open-mpi.org/community/lists/devel/2015/07/17600.php

diff --git a/config/ompi_check_openfabrics.m4 b/config/ompi_check_openfabrics.m4
index d4e562c..797c987 100644
--- a/config/ompi_check_openfabrics.m4
+++ b/config/ompi_check_openfabrics.m4
@@ -171,7 +171,7 @@ AC_DEFUN([OMPI_CHECK_OPENFABRICS],[
                AC_CHECK_FUNCS([ibv_create_xrc_rcv_qp ibv_cmd_open_xrcd],
                               [], [$1_have_xrc=0])
                AC_CHECK_DECLS([IBV_SRQT_XRC],
-                              [], [$1_have_xrc=0])
+                              [], [$1_have_xrc=0],
                               [#include <infiniband/verbs.h>])
            fi
            if test "$enable_connectx_xrc" = "yes" \

Reply via email to