FWIW: we do have a macro that safely returns the either field of the jobid, whether in 32 or 64 bit environments. Is there some reason not to just use those?
> On Feb 5, 2016, at 3:58 PM, Gilles Gouaillardet > <gilles.gouaillar...@gmail.com> wrote: > > Jeff, > > first, cutoff currently assumes sizeof(intptr_t) == > sizeof(opal_process_name_t) > I will double check cutoff is automatically disabled or cannot be set on > 32bits arch > > iirc, I used an explicit unsigned long because the MSB is not cleared when > right shifting > > Cheers, > > Gilles > > On Saturday, February 6, 2016, Jeff Squyres (jsquyres) <jsquy...@cisco.com > <mailto:jsquy...@cisco.com>> wrote: > On Feb 5, 2016, at 9:26 AM, Gilles Gouaillardet > <gilles.gouaillar...@gmail.com <javascript:;>> wrote: > > > > static inline opal_process_name_t ompi_proc_sentinel_to_name (intptr_t > > sentinel) > > { > > sentinel >>= 1; > > sentinel &= 0x7FFFFFFFFFFFFFFF; > > return *((opal_process_name_t *) &sentinel); > > } > > I don't have much of an opinion on any of the other stuff here, but I note > that this is unsafe. I know we don't really care about non-64 bit these > days, but we shouldn't be knowingly breaking it. Instead of ANDing with a > fixed constant, shouldn't it be something like: > > intptr_t mask = ~1 >> 1; > sentinel &= mask; > > -- > Jeff Squyres > jsquy...@cisco.com <javascript:;> > For corporate legal information go to: > http://www.cisco.com/web/about/doing_business/legal/cri/ > <http://www.cisco.com/web/about/doing_business/legal/cri/> > > _______________________________________________ > devel mailing list > de...@open-mpi.org <javascript:;> > Subscription: http://www.open-mpi.org/mailman/listinfo.cgi/devel > <http://www.open-mpi.org/mailman/listinfo.cgi/devel> > Link to this post: > http://www.open-mpi.org/community/lists/devel/2016/02/18557.php > <http://www.open-mpi.org/community/lists/devel/2016/02/18557.php> > _______________________________________________ > devel mailing list > de...@open-mpi.org > Subscription: http://www.open-mpi.org/mailman/listinfo.cgi/devel > Link to this post: > http://www.open-mpi.org/community/lists/devel/2016/02/18560.php
