Ok. I started a PR here: https://github.com/open-mpi/ompi/pull/1639
I want to do a bit of testing (building now), but this should be an easy fix. Thanks On Thu, May 5, 2016 at 3:07 PM, Jeff Squyres (jsquyres) <jsquy...@cisco.com> wrote: > Agreed, this looks like an oversight. > > In dl.h, I even said that you could pass NULL as fname: > > https://github.com/open-mpi/ompi/blob/master/opal/mca/dl/dl.h#L67 > > These asserts can safely be removed. Thanks! > > > > On May 5, 2016, at 3:40 PM, Josh Hursey <jjhur...@open-mpi.org> wrote: > > > > We noticed that there is an assert(fname) in both of the dl components: > > * > https://github.com/open-mpi/ompi/blob/master/opal/mca/dl/dlopen/dl_dlopen_module.c#L53 > > * > https://github.com/open-mpi/ompi/blob/master/opal/mca/dl/libltdl/dl_libltdl_module.c#L21 > > > > But according to the dl.h, NULL should be an acceptable parameter for > fname: > > https://github.com/open-mpi/ompi/blob/master/opal/mca/dl/dl.h#L67 > > > > For dlopen() it returns a handle to the program space, which can be > handy. > > > > > > I think it was just an oversight in the original code that has not been > encountered yet. But before I work on a patch, I wanted to check to see if > was a reason to put the assert in the code. git blame says that Jeff > Squyres put this code in there a while back, so I don't know if he > remembers. > > > > Thanks, > > Josh > > _______________________________________________ > > devel mailing list > > de...@open-mpi.org > > Subscription: https://www.open-mpi.org/mailman/listinfo.cgi/devel > > Link to this post: > http://www.open-mpi.org/community/lists/devel/2016/05/18912.php > > > -- > Jeff Squyres > jsquy...@cisco.com > For corporate legal information go to: > http://www.cisco.com/web/about/doing_business/legal/cri/ > > _______________________________________________ > devel mailing list > de...@open-mpi.org > Subscription: https://www.open-mpi.org/mailman/listinfo.cgi/devel > Link to this post: > http://www.open-mpi.org/community/lists/devel/2016/05/18913.php >
