[OMPI devel] SHMEM, "mpp/shmem.fh", CMake and infinite loops

[Paul Kapinos]

Dear OpenMPI developer,

we have some troubles when using OpenMPI and CMake on codes using 'SHMEM'.

Cf. 'man shmem_swap',
>       Fortran:
>       INCLUDE "mpp/shmem.fh"

Yes here is one such header file:
> openmpi-1.X.Y/oshmem/include/mpp/shmem.fh
... since version 1.7. at least.


The significnat content is this line:
>      include 'shmem.fh'

> openmpi-1.X.Y/oshmem/include/shmem.fh






Steps to repriduce:
$ mkdir build; cd build; cmake ..
$ make





*Well, maybe having a file including the same file is not that good?*




Have a nice day,

Paul Kapinos

..............

fstat(5271, {st_mode=S_IFREG|0644, st_size=205, ...}) = 0

read(5271, "!\n!   Copyright (c) 2013      Me"..., 32768) = 205
read(5271, "", 32768)                   = 0


fstat(5272, {st_mode=S_IFREG|0644, st_size=205, ...}) = 0

read(5272, "!\n!   Copyright (c) 2013      Me"..., 32768) = 205
read(5272, "", 32768)                   = 0
..............

--
Dipl.-Inform. Paul Kapinos   -   High Performance Computing,
RWTH Aachen University, IT Center
Seffenter Weg 23,  D 52074  Aachen (Germany)
Tel: +49 241/80-24915

cmake_minimum_required(VERSION 2.8)
project(mpihelloworld)
enable_language(Fortran)
find_package(MPI REQUIRED)

#include_directories(${MPI_INCLUDE_PATH})
include_directories(${MPI_Fortran_INCLUDE_PATH})

add_executable(mpihelloworld mpihelloworld.F90)
#link_directories(${MPI_LIBRARIES})
#target_link_libraries(mpihelloworld ${MPI_LIBRARIES})

link_directories(${MPI_Fortran_LIBRARIES})
target_link_libraries(mpihelloworld ${MPI_Fortran_LIBRARIES})

! Paul Kapinos 22.09.2009 - 
! RZ RWTH Aachen, www.rz.rwth-aachen.de
!
! MPI-Hello-World
!
PROGRAM PK_MPI_Test

! USE MPI
IMPLICIT NONE
include "mpif.h"
#if defined(SHMEM)
INCLUDE "mpp/shmem.fh"
#endif

!
INTEGER :: my_MPI_Rank, laenge, ierr
CHARACTER*(MPI_MAX_PROCESSOR_NAME) my_Host

CALL MPI_INIT (ierr)
CALL MPI_COMM_RANK( MPI_COMM_WORLD, my_MPI_Rank, ierr )
CALL MPI_GET_PROCESSOR_NAME(my_Host, laenge, ierr)
WRITE (*,*) "Prozessor ", my_MPI_Rank, "on Host: ", my_Host(1:laenge)

CALL Sleep(1)

CALL MPI_FINALIZE(ierr)

CONTAINS

SUBROUTINE foo1
#if defined(SHMEM)
INCLUDE "mpp/shmem.fh"
#endif
END SUBROUTINE foo1

SUBROUTINE foo2
#if defined(SHMEM)
INCLUDE "mpp/shmem.fh"
#endif
END SUBROUTINE foo2

SUBROUTINE foo3
#if defined(SHMEM)
INCLUDE "mpp/shmem.fh"
#endif
END SUBROUTINE foo3

SUBROUTINE foo4
#if defined(SHMEM)
INCLUDE "mpp/shmem.fh"
#endif
END SUBROUTINE foo4

SUBROUTINE foo5
#if defined(SHMEM)
INCLUDE "mpp/shmem.fh"
#endif
END SUBROUTINE foo5


END PROGRAM PK_MPI_Test

whereby OpenMPI mean to include not the same file by itself (= infinite loop!) but I believe these one file: (The above paths are in the source code distributions; in the installation the files are located here: include/shmem.fh include/mpp/shmem.fh) This works. Unless you start using CMake. Because CMake is 'intelligent' and try to add the search paths recursively, (I believe,) gloriously enabling the infinite loop by including the 'shmem.fh' file from the 'shmem.fh' file. The second one command need some minute(s), sticking by the 'Scanning dependencies of target mpihelloworld' step. If connecting by 'strace -p <PID>' to the 'cmake' process you will see lines like below, again and again. So I think CMake just include the 'shmem.fh' file from itself unless the stack is full / a limit is reached / the moon shines, and thus hangs for a while (seconds/minutes) in the 'Scanning dependencies...' state. If the file 'include/mpp/shmem.fh' would include not 'shmem.fh' but 'somethingelse.fh' located in 'include/...' these infinite loop would be impossible at all... And by the way: is here a way to limit the maximum include depths in CMake for header files? This would workaround this one 'infinite include loop' issue... access("/opt/MPI/openmpi-1.10.2/linux/intel_16.0.2.181/include/mpp/shmem.fh", R_OK) = 0 stat("/opt/MPI/openmpi-1.10.2/linux/intel_16.0.2.181/include/mpp/shmem.fh", {st_mode=S_IFREG|0644, st_size=205, ...}) = 0 open("/opt/MPI/openmpi-1.10.2/linux/intel_16.0.2.181/include/mpp/shmem.fh", O_RDONLY) = 5271 mmap(NULL, 32768, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x7f08457d2000 access("/opt/MPI/openmpi-1.10.2/linux/intel_16.0.2.181/include/mpp/shmem.fh", R_OK) = 0 stat("/opt/MPI/openmpi-1.10.2/linux/intel_16.0.2.181/include/mpp/shmem.fh", {st_mode=S_IFREG|0644, st_size=205, ...}) = 0 open("/opt/MPI/openmpi-1.10.2/linux/intel_16.0.2.181/include/mpp/shmem.fh", O_RDONLY) = 5272 mmap(NULL, 32768, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x7f08457ca000

smime.p7s
Description: S/MIME Cryptographic Signature