We seem to have gotten into a state again of generating a ton of warnings on master - can folks take a look at these and clean them up?
opal_datatype_pack.c: In function ‘pack_predefined_heterogeneous’: opal_datatype_pack.c:421:24: warning: variable ‘_l_blength’ set but not used [-Wunused-but-set-variable] size_t _r_blength, _l_blength; ^~~~~~~~~~ opal_datatype_pack.c: In function ‘opal_pack_general_checksum’: opal_datatype_pack.c:467:9: warning: variable ‘type’ set but not used [-Wunused-but-set-variable] int type; ^~~~ opal_datatype_pack.c: In function ‘pack_predefined_heterogeneous’: opal_datatype_pack.c:421:24: warning: variable ‘_l_blength’ set but not used [-Wunused-but-set-variable] size_t _r_blength, _l_blength; ^~~~~~~~~~ opal_datatype_pack.c: In function ‘opal_pack_general’: opal_datatype_pack.c:467:9: warning: variable ‘type’ set but not used [-Wunused-but-set-variable] int type; ^~~~ topology.c: In function ‘hwloc__check_children’: topology.c:3126:9: warning: variable ‘prev_firstchild’ set but not used [-Wunused-but-set-variable] int prev_firstchild = -1; /* -1 works fine with first comparisons below */ ^~~~~~~~~~~~~~~ At top level: topology.c:637:31: warning: ‘obj_order_type’ defined but not used [-Wunused-const-variable=] static const hwloc_obj_type_t obj_order_type[] = { ^~~~~~~~~~~~~~ topology-xml.c: In function ‘opal_hwloc1113_hwloc_export_obj_userdata’: topology-xml.c:1632:5: warning: ‘realname’ may be used uninitialized in this function [-Wmaybe-uninitialized] hwloc__export_obj_userdata(state, encoded, realname, length, buffer, encoded_length); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ topology-xml.c:1632:5: warning: ‘encoded_length’ may be used uninitialized in this function [-Wmaybe-uninitialized] topology-xml.c:1632:5: warning: ‘encoded’ may be used uninitialized in this function [-Wmaybe-uninitialized] class/opal_free_list.c: In function ‘opal_free_list_grow_st’: class/opal_free_list.c:217:21: warning: ‘align’ may be used uninitialized in this function [-Wmaybe-uninitialized] payload_ptr = (unsigned char *) flist->fl_mpool->mpool_alloc(flist->fl_mpool, buffer_size, align, 0); ~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ class/opal_free_list.c:217:21: warning: ‘buffer_size’ may be used uninitialized in this function [-Wmaybe-uninitialized] server/pmix_server.c: In function ‘PMIx_server_init’: server/pmix_server.c:438:83: warning: ‘tl’ may be used uninitialized in this function [-Wmaybe-uninitialized] pmix_show_help("help-pmix-server.txt", "listener-failed-start", true, tl->address.sun_path); ^~ rcache_grdma_module.c: In function ‘mca_rcache_grdma_check_cached’: rcache_grdma_module.c:235:17: warning: unused variable ‘ref_cnt’ [-Wunused-variable] int32_t ref_cnt = opal_atomic_add_32 (&grdma_reg->ref_count, 1); ^~~~~~~ runtime/orte_init.c:129:2: warning: #ident is a GCC extension coll_basic_reduce_scatter.c: In function ‘mca_coll_basic_reduce_scatter_inter’: coll_basic_reduce_scatter.c:474:9: warning: ‘lbuf’ may be used uninitialized in this function [-Wmaybe-uninitialized] err = comm->c_local_comm->c_coll.coll_scatterv(lbuf, rcounts, disps, dtype, ~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ rbuf, rcounts[rank], dtype, 0, ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ comm->c_local_comm, ~~~~~~~~~~~~~~~~~~~ comm->c_local_comm->c_coll.coll_scatterv_module); ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ coll_basic_alltoallw.c: In function ‘mca_coll_basic_alltoallw_intra’: coll_basic_alltoallw.c:71:16: warning: ‘gap’ may be used uninitialized in this function [-Wmaybe-uninitialized] tmp_buffer -= gap; ^~ coll_basic_alltoallw.c:47:20: note: ‘gap’ was declared here ptrdiff_t ext, gap; ^~~ In file included from osc_pt2pt_module.c:23:0: osc_pt2pt.h: In function ‘osc_pt2pt_gc_clean’: osc_pt2pt.h:668:21: warning: unused variable ‘request’ [-Wunused-variable] ompi_request_t *request; ^~~~~~~ osc_pt2pt_module.c: In function ‘ompi_osc_pt2pt_free’: osc_pt2pt_module.c:96:28: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (int i = 0 ; i < module->recv_frag_count ; ++i) { ^ In file included from osc_pt2pt_frag.c:15:0: osc_pt2pt.h: In function ‘osc_pt2pt_gc_clean’: osc_pt2pt.h:668:21: warning: unused variable ‘request’ [-Wunused-variable] ompi_request_t *request; ^~~~~~~ In file included from osc_pt2pt_active_target.c:26:0: osc_pt2pt.h: In function ‘osc_pt2pt_gc_clean’: osc_pt2pt.h:668:21: warning: unused variable ‘request’ [-Wunused-variable] ompi_request_t *request; ^~~~~~~ In file included from osc_pt2pt_component.c:30:0: osc_pt2pt.h: In function ‘osc_pt2pt_gc_clean’: osc_pt2pt.h:668:21: warning: unused variable ‘request’ [-Wunused-variable] ompi_request_t *request; ^~~~~~~ In file included from osc_pt2pt_sync.c:12:0: osc_pt2pt.h: In function ‘osc_pt2pt_gc_clean’: In file included from osc_pt2pt_comm.c:25:0: osc_pt2pt.h: In function ‘osc_pt2pt_gc_clean’: osc_pt2pt.h:668:21: warning: unused variable ‘request’ [-Wunused-variable] ompi_request_t *request; ^~~~~~~ osc_pt2pt.h:668:21: warning: unused variable ‘request’ [-Wunused-variable] ompi_request_t *request; ^~~~~~~ In file included from osc_pt2pt_data_move.c:25:0: osc_pt2pt.h: In function ‘osc_pt2pt_gc_clean’: osc_pt2pt.h:668:21: warning: unused variable ‘request’ [-Wunused-variable] ompi_request_t *request; ^~~~~~~ In file included from osc_pt2pt_request.c:23:0: osc_pt2pt.h: In function ‘osc_pt2pt_gc_clean’: osc_pt2pt.h:668:21: warning: unused variable ‘request’ [-Wunused-variable] ompi_request_t *request; ^~~~~~~ In file included from osc_pt2pt_passive_target.c:27:0: osc_pt2pt.h: In function ‘osc_pt2pt_gc_clean’: osc_pt2pt.h:668:21: warning: unused variable ‘request’ [-Wunused-variable] ompi_request_t *request; ^~~~~~~ osc_pt2pt_data_move.c: In function ‘ompi_osc_pt2pt_process_receive’: osc_pt2pt_data_move.c:1638:9: warning: variable ‘rc’ set but not used [-Wunused-but-set-variable] int rc; ^~ osc_pt2pt_data_move.c: In function ‘ompi_osc_pt2pt_frag_start_receive’: osc_pt2pt_data_move.c:1701:24: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (int i = 0 ; i < module->recv_frag_count ; ++i) { ^ treematch/tm_malloc.c: In function ‘my_mem_check’: treematch/tm_malloc.c:58:7: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation] if(get_verbose_level()>=ERROR) ^~ treematch/tm_malloc.c:60:2: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the ‘if’ nb_errors ++; ^~~~~~~~~ treematch/tm_tree.c: In function ‘group_nodes’: treematch/tm_tree.c:1171:5: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation] if(verbose_level>=INFO) ^~ treematch/tm_tree.c:1174:7: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the ‘if’ compute_weighted_degree(tab_group,n,arity); ^~~~~~~~~~~~~~~~~~~~~~~ In file included from spml_yoda.c:25:0: spml_yoda.c: In function ‘mca_spml_yoda_add_procs’: spml_yoda.c:645:33: warning: passing argument 1 of ‘mca_pml.pml_add_procs’ from incompatible pointer type [-Wincompatible-pointer-types] rc = MCA_PML_CALL(add_procs(procs, nprocs)); ^ ../../../../ompi/mca/pml/pml.h:550:41: note: in definition of macro ‘MCA_PML_CALL’ #define MCA_PML_CALL(a) mca_pml.pml_ ## a ^ spml_yoda.c:645:33: note: expected ‘struct ompi_proc_t **’ but argument is of type ‘oshmem_proc_t ** {aka struct oshmem_proc_t **}’ rc = MCA_PML_CALL(add_procs(procs, nprocs)); ^ ../../../../ompi/mca/pml/pml.h:550:41: note: in definition of macro ‘MCA_PML_CALL’ #define MCA_PML_CALL(a) mca_pml.pml_ ## a ^ monitoring_test.c:81:19: warning: ‘flush_cvar_name’ defined but not used [-Wunused-const-variable=] static const char flush_cvar_name[] = "pml_monitoring_enable"; ^~~~~~~~~~~~~~~ l _______________________________________________ devel mailing list devel@lists.open-mpi.org https://rfd.newmexicoconsortium.org/mailman/listinfo/devel