On Friday 10 April 2009 10:44:26 pm Paolo Abeni wrote: > hello, > > On Wed, Apr 8, 2009 at 2:08 AM, Brad Hards <[email protected]> wrote: > > The patch looks fine, but it would be useful if we had a mapitest that > > showed the problem (i.e. shows the failure without the patch, and shows > > success with the patch). If you have time, can you write one? > > Please find in attachment an example program that outline the issue. > Without the patch the Unsubscribe() call fails; with the patch applied > the program complete successfully. I converted your example program to a mapitest case. I had to add a new test suite, because we didn't appear to have any unit tests for notifications. The reason for adding it to mapitest is that mapitest is routinely run by developers (and by the buildbot) to detect any errors that may have crept in. So this gives more confidence in any changes, and prevents regression.
You can see the new test case in r1306. I tried to keep the code very close to what you used in your example, so you can see how I incorporated it. I also applied your fix (from your original email) as r1307. Thanks again for the investigation, the patch and the test case. Much appreciated. Brad _______________________________________________ devel mailing list [email protected] http://mailman.openchange.org/listinfo/devel
