Hi Brad, Thanks for replying :)
On Tue, Aug 4, 2009 at 14:51, Brad Hards<[email protected]> wrote: > On Tuesday 04 August 2009 21:19:18 Kamen Mazdrashki wrote: > > Hi all, > Hi Kamen, > > > Here is a patch for NspiResolveNames/W torture test > Thanks. > > > Basically, the test has been reimplemented - it is now a test case > with 3 > > tests. A new file nspi_torture.c is added - it is intended to > accommodate > > helper functions. For example for checking returned values for being > valid, > > gathering data for tests using LDAP etc. - still in progress and I > will > > send it later this week. > > > > Please review. > I am not very familiar with this part of the code, and I know Julien is > quite > busy with non-OpenChange stuff at the moment, so this may not be able > to be > reviewed quickly. > > One thing you might like to consider is writing your changes for > mapitest, > rather than for the torture suite. I usually run mapitest, and almost > never > run smbtorture. Its just easier to run and has better tests in some > areas. Actually this is what I wanted to avoid in first place - using MAPI client layer to particularly test NSPI implementation. In my mind, testing directly NSPI interfaces should be much cleaner and easy to support in future. We may just use nspi_torture implementation to test any implementation of NSPI interface - no need to set Mapi profiles or whatsoever. Regards, Kamen _______________________________________________ devel mailing list [email protected] http://mailman.openchange.org/listinfo/devel
