Hi Kamen, I've been working on review and integration of your patches for the last few days. Finally, there are only 3 minor patches that didn't enter trunk:
0011-Properties-mapping-reimplemented.patch
===========================================
I understand the logic behind, however I'm not a big fan of
these macros. I've tried to use them in the past, but I find it
obfuscates the code rather than make it more clear. I'd prefer
to keep the existing code `as it is` until the interest of these
macros is clearly demonstrated.
0009--tort-Implement-more-straightforward-test-Nspi_Reso.patch
0010--tort-NspiQueryRows-torture-test-implementation.patch
===============================================================
I think Brad already discussed this in a previous email.
OpenChange is now using its mapitest utility rather than the
torture test. The mapitest framework and report makes it easier
for us to detect regression over revisions.
Refactoring these tests into mapitest sub unit would be more
useful.
On Fri, 2009-12-11 at 05:29 +0200, Kamen Mazdrashki wrote:
> Hi Julien,
>
> I've tried to refactor NSPI implementation patches to be more 'feature
> oriented'.
> Those patches are available at:
> http://repo.or.cz/w/OpenChange-git-clone.git/shortlog/refs/heads/nspi_merge
> (and also attached to this mail)
> I hope this will help merging the code.
>
>
> CU,
> Kamen Mazdrashki
> [email protected]
> http://repo.or.cz/w/Samba/kamenim.git
> -------------------------------------
> CISCO SYSTEMS BULGARIA EOOD
> http://www.cisco.com/global/BG/
>
> > -----Original Message-----
> > From: [email protected] [mailto:devel-
> > [email protected]] On Behalf Of Julien Kerihuel
> > Sent: Thursday, December 10, 2009 7:24 PM
> > To: '[email protected]'
> > Subject: [openchange][devel] NSPI Implementation Follow-up
> >
> > Hi List,
> >
> > This mail follows on the excellent and time consuming work Kamen
> > Mazdrashki has been provided to OpenChange NSPI server implementation
> > over the past months.
> >
> > First of all, I truly want to apologize to Kamen for the lack of
> > follow-up and answers his work deserved.
> >
> > Secondly, I am willing to delay openchange 0.9 release a few days so I
> > can merge into trunk your work.
> >
> > Now the technical part ... I have started to review all the emails and
> > patches you have sent to the list since your initial mail on July, 3rd
> > 2009. You'll find in current and forthcoming emails comments or svn rev
> > notification about all the different patches.
> >
> > Let's start with the following:
> > =======================================================================
> > ==
> > 1. emsabp.c:emsabp_init() function uses 'ldb_wrap_connect()' to open
> > .ldb databases. Primary motivation for this was to be able to handle
> > extended syntaxes correctly (ldb_register_samba_handlers() should be
> > called prior opening .ldb file)
> >
> > 17. LDB connection fix - previously there were two connections opened -
> > for users.ldb and configuration.ldb. This way LDAP queries for certain
> > attributes didn't pass - for example 'objectCategory' attribute. Those
> > two connections were replaced with a connection to 'sam.ldb' and code
> > was refactored accordingly.
> > =======================================================================
> > ===
> >
> > I've applied a similar fix in r1575 to comply with latest samba4
> > requirement and the new sam.ldb + sam.ldb.d database architecture. I
> > had been using samdb_connect, but this is just a wrapper over
> > ldb_wrap_connect (furthermore generating a warning because of the
> > missing header declaration), I'll replace with this call in further
> > commit.
> >
> >
> > Regarding all the other patches, I've read the associated discussion +
> > gave a quick look at the associated code and at this point I must say I
> > agree with almost all your changes and propositions.
> >
> > However, to keep the code in good shape and given that current trunk
> > rev slightly differs from the one you have been using, I'll apply the
> > changes step by step, one after the other.
> >
> > I'll keep the list informed within this thread about changes/progress
> > on this with a generous planned number of emails ;-)
> >
> > Cheers,
> > Julien.
> >
> >
> > Julien Kerihuel
> > [email protected]
> > OpenChange Project Manager
> >
> > GPG Fingerprint: 0B55 783D A781 6329 108A B609 7EF6 FE11 A35F 1F79
> >
>
--
Julien Kerihuel
[email protected]
OpenChange Project Manager
GPG Fingerprint: 0B55 783D A781 6329 108A B609 7EF6 FE11 A35F 1F79
signature.asc
Description: This is a digitally signed message part
_______________________________________________ devel mailing list [email protected] http://mailman.openchange.org/listinfo/devel
