On Fri, 2010-05-28 at 20:27 +0200, Julien Kerihuel wrote: > On Thu, 2010-05-27 at 21:13 +0530, Bharath Acharya wrote: > > Hello, > > > > I was testing the FreeBusy feature using the openchangeclient tool, > > and I found some entries missing from the results displayed. Browsing > > through the dump I noticed we fetch all the entries, but we did not > > display the calendar items which were created at half hours, example an > > event at 0430 hours. > > > > I made a few changes and the resulting string looked very long and > > wordy. So I have modified the print statements to display it in the > > following format, > > > > 7th June 2010 0430 hrs and lasts 1 hr 30 mins. > > > > Even better would be the following format, > > 7th June 2010 0430 hrs Duration: 1 hr 30 mins. > > > > Let me know if I need to change anything else. > > The patch sounds OK to me, it just need a formal test. > > Will try to do it during the week-end, otherwise if you have a > before/after output log to validate it, this would be much appreciated.
Sure, pasting the output log, Before the change, http://paste.pocoo.org/show/220228/ After the change, http://paste.pocoo.org/show/220229/ The missing set of entries clearly visible between the two sets. Also while committing, please add a %.2u format for the day output as well, that should align it better while displaying, Example, * 9 May 2010 at 1100 hrs and lasts 2 hrs 30 mins * 13 May 2010 at 0430 hrs and lasts 30 minutes making it 09 May, the output would look well formatted. Let me know if you need any details. Regards, Bharath > > Cheers, > Julien. > > _______________________________________________ > devel mailing list > [email protected] > http://mailman.openchange.org/listinfo/devel _______________________________________________ devel mailing list [email protected] http://mailman.openchange.org/listinfo/devel
