Le Vendredi 3 Juin 2011 06:39 EDT, Brad Hards <[email protected]> a écrit: > Hi Wolfgang, > > I've been looking a bit at your IDSET parser code. Looks nice, and I'd like > to > try to merge that into trunk. > > However I'm not sure I understand the "can skip" bool that you have in a few > places. Can you help me out here? > > Also, are there any unit tests or other examples that I should work from? I > do > plan to add tests and docs as part of the merge to trunk. > > Brad Hi Brad,
The can_skip parameter is just a flag to indicate whether the globset range can "skip" unlisted entities. In particular, in FXICS we have 2 main idsets: the cnset (change numbers) and eidset (fmid). Since the change number must be incremented and must be unique across all exchange objects, you can enable this flag to reduce the amount of data to transfer over the wire. For the fmids, on the contrary, this cannot be done since you may miss certain entries. If you want my opinion, I find the underlying logic quite strange and complicated for nothing. Before integrating the changes in trunk, you should wait for another commit which greatly simplifies the API, and where "can_skip" has been renamed to "single". If you have a better name for this, please tell... I should commit this today so my guess is that you will see this at your first cup of coffee. -- Wolfgang Sourdeau :: +1 (514) 447-4918 ext. 125 :: [email protected] Inverse inc. Leaders behind SOGo (sogo.nu) and PacketFence (www.packetfence.org) _______________________________________________ devel mailing list [email protected] http://mailman.openchange.org/listinfo/devel
