On Monday 17 December 2007, Bogdan-Andrei Iancu wrote:
> Hi Henning,
>
> I think this needs a bit of a re-work as what it supposed to be in
> modules ended up in core. The solution is to have a generic LM_ function
> where you can pass facility as argument. So, the ACC facility will be a
> module parameter for acc module - the same as the "log_level". See:
>     http://www.openser.org/docs/modules/1.3.x/acc.html#AEN268
>
> So, my suggestion is to revert this commit and let me add this generic
> logging function (which anyhow is needed by other modules, like xlog)
> and to add the configurable facility as acc module param.

Hi Bogdan,

yes, this really belongs more to the module code. But this patch was getting 
really stale in my repository, and i do not wanted to extend the logging 
interface only for this module. I was also not aware the the xlog module 
needs the same interface extension.

I revert the commit later. 

Cheers,

Henning

_______________________________________________
Devel mailing list
[email protected]
http://lists.openser.org/cgi-bin/mailman/listinfo/devel

Reply via email to