On 03/06/08 16:10, Henning Westerholt wrote: > On Thursday 06 March 2008, Daniel-Constantin Mierla wrote: > >> Revision: 3868 >> http://openser.svn.sourceforge.net/openser/?rev=3868&view=rev >> Author: miconda >> Date: 2008-03-06 05:05:01 -0800 (Thu, 06 Mar 2008) >> >> Log Message: >> ----------- >> - don't free dbtext values in core DB api, the module will free along with >> the internal structure (related to #1891453 reported by Ovidiu Sas) - >> formatted some logs to fit 80char line >> > > Thank you Daniel for the fix. Just a short note to prevent confusion if > somebody reviews the other drivers.. Its not strictly necessary to set this > free-flag explicit to zero, as the used structure is initialized with a > memset, so its already zero. > Yes, you are right. Just wanted to check more about and get your feedback. I was digging in to see what free is done in core and what still has to be in module. I think db_text should be updated to get the result directly in the core format, avoiding the intermediary format. It is why I just did the quick fix, maybe the time will allow to do it directly to db_res_t before 1.4, and then the free will be done in core again.
Cheers, Daniel > Cheers, > > Henning > _______________________________________________ Devel mailing list [email protected] http://lists.openser.org/cgi-bin/mailman/listinfo/devel
