Hi Juha! Yes it was "quick and dirty" patch.
I was thinking about using generic code too and I agree that such code may be included into core with some #ifdef IMHO This code derived from acc-module and its may be useful to share it with this module too. If this patch is interesting then I can make some improvements and apply it for current release > Comment By: Juha Heinanen (juhe)Date: 2008-04-19 17:03 > > Message: > Logged In: YES > user_id=1332122 > Originator: NO > > i looked at the patches and have a couple of comments: > > - in order to cleanly separate the new code, i would like to include a > test if extra attributes are present to sterman.c and checks.c before > add_extra_2_radius is called. > > - uri_radius module includes extra_attrs.h from auth_radius module. i > don't know if that is according to openser policy. if there is common > code, perhaps it should be included in core. > > - documentation diffs should also be included. > > -- juha _______________________________________________ Devel mailing list [email protected] http://lists.openser.org/cgi-bin/mailman/listinfo/devel
