Patches item #3058434, was opened at 2010-09-03 01:55 Message generated for change (Comment added) made by anca_vamanu You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=1086412&aid=3058434&group_id=232389
Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: modules Group: trunk >Status: Closed >Resolution: Accepted Priority: 5 Private: No Submitted By: Kennard White (kennardwhite) Assigned to: Anca Vamanu (anca_vamanu) Summary: presence mix_offline_presence parameter Initial Comment: Add new module parameter "mix_offline_presence" to presence module. This borrows a subset of the pre-existing "mix_dialog_presence" functionality to create a default PIDF with basic status 'closed' when there are no available presentities. ---------------------------------------------------------------------- >Comment By: Anca Vamanu (anca_vamanu) Date: 2010-09-10 17:28 Message: Hi Kennard, Thank you. I will close this patch report. Regards, Anca ---------------------------------------------------------------------- Comment By: Kennard White (kennardwhite) Date: 2010-09-09 23:15 Message: I integrated with Anca's version in trunk and everything is fine. I didn't do detail verification of the other issue fixed at the same time (too early delete from hash table on expire) but it at least doesn't break anything. ---------------------------------------------------------------------- Comment By: Kennard White (kennardwhite) Date: 2010-09-03 19:09 Message: Hi Anca, I don't have preference for what parameter is called. Will you make the module parameter name change when you commit, or would you like me to generate a different patch file? Thanks, Kennard ---------------------------------------------------------------------- Comment By: Anca Vamanu (anca_vamanu) Date: 2010-09-03 19:00 Message: HI Kennard, I agree that this feature is useful and I appreciate that you analyzed the code and discovered that the functionalities added for mix_dialog_presence can very easily be used. I would however change the name of this parameter - maybe in something like 'use_default_closed_body'. Regards, Anca ---------------------------------------------------------------------- Comment By: Anca Vamanu (anca_vamanu) Date: 2010-09-03 11:49 Message: Hi Kennard, I will review your patch. Regards, Anca ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=1086412&aid=3058434&group_id=232389 _______________________________________________ Devel mailing list [email protected] http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
