Hello Maxim, All should be good now. Sorry for the trouble. I'm working on this part of the code, running tests and I would've caught the issue soon. We rushed with the backport based only on code inspection, so "mea culpa" here :)
Thanks for the fast report, Ovidiu On Mon, Feb 5, 2018 at 3:40 PM, Maxim Sobolev <sobo...@sippysoft.com> wrote: > Thanks, regardless I am glad somebody took care of refactoring that old > code, but please be more careful with merging it down into stable branches. > :) I've just made a change to request a daily build of the voiptests, so > consider keeping an eye on it after making changes in master branch. > > It is just happens you caught me in the process of merging python 3.x > support in the sippy so it's a bit of an unexpected obstacle for us here. > > -Max > > On Mon, Feb 5, 2018 at 12:24 PM, Ovidiu Sas <o...@voipembedded.com> wrote: >> >> Hello Maxim, >> >> I think I know what the issue is. There was a confusion between >> variable naming: oldpf and newpf refers to protocol format and not the >> actual IP. >> I will revert the changes! >> >> -ovidiu >> >> On Mon, Feb 5, 2018 at 3:06 PM, Maxim Sobolev <sobo...@sippysoft.com> >> wrote: >> > That merge broke all of our OpenSIPS test scenarous on voiptests. We are >> > investigating about the possible cause but I think this change may need >> > to >> > be reverted from the stable branches until it's clear what's going on. >> > >> > -Maxim >> > >> > On Mon, Feb 5, 2018 at 10:04 AM, Ovidiu Sas <o...@voipembedded.com> >> > wrote: >> >> >> >> Branch: refs/heads/2.3 >> >> Home: https://github.com/OpenSIPS/opensips >> >> Commit: a45d4dcaf046bb273cfe5905ac035845a6867945 >> >> >> >> >> >> https://github.com/OpenSIPS/opensips/commit/a45d4dcaf046bb273cfe5905ac035845a6867945 >> >> Author: Ovidiu Sas <o...@voipembedded.com> >> >> Date: 2018-02-05 (Mon, 05 Feb 2018) >> >> >> >> Changed paths: >> >> M modules/nathelper/nathelper.c >> >> >> >> Log Message: >> >> ----------- >> >> nathelper: manual backport for >> >> 3c39167e333a8801772f49f8561a015bfa1836f1 >> >> - fix test condition for updateing IP for fix_nated_sdp() >> >> >> >> >> >> >> >> _______________________________________________ >> >> Devel mailing list >> >> Devel@lists.opensips.org >> >> http://lists.opensips.org/cgi-bin/mailman/listinfo/devel >> >> >> > >> > >> > >> > -- >> > Maksym Sobolyev >> > Sippy Software, Inc. >> > Internet Telephony (VoIP) Experts >> > Tel (Canada): +1-778-783-0474 >> > Tel (Toll-Free): +1-855-747-7779 >> > Fax: +1-866-857-6942 >> > Web: http://www.sippysoft.com >> > MSN: sa...@sippysoft.com >> > Skype: SippySoft >> >> >> >> -- >> VoIP Embedded, Inc. >> http://www.voipembedded.com > > > > > -- > Maksym Sobolyev > Sippy Software, Inc. > Internet Telephony (VoIP) Experts > Tel (Canada): +1-778-783-0474 > Tel (Toll-Free): +1-855-747-7779 > Fax: +1-866-857-6942 > Web: http://www.sippysoft.com > MSN: sa...@sippysoft.com > Skype: SippySoft -- VoIP Embedded, Inc. http://www.voipembedded.com _______________________________________________ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
