P. A. Bagyenda wrote:
Jason,

Thanks. It would be nice to see a full patch against latest CVS for this.

As I've said, my version of Mbuni is drastically different from CVS. :) I'll see what I can do.

On Sep 19, 2008, at 02:16, Jason Pollock wrote:

P. A. Bagyenda wrote:
Thanks for the review.

If you would, kindly share a non-destructive patch for further discussion.

Here are the changes that I applied based on the comments.


Index: mms_util.c
===================================================================
RCS file: /home/cvs/MBUNI/mmlib/mms_util.c,v
retrieving revision 1.4
diff -a -u -r1.4 mms_util.c
--- mms_util.c    10 Sep 2008 04:04:09 -0000    1.4
+++ mms_util.c    18 Sep 2008 23:15:09 -0000
@@ -22,9 +22,9 @@
#include <fcntl.h>
#include <pthread.h>
#include <sys/types.h>
-#include <sys/stat.h>
#endif

+#include <sys/stat.h>
#include <errno.h>
#include <sys/types.h>
#include <sys/stat.h>
@@ -929,9 +929,8 @@
    key.dev   = buf.st_dev;

    release_file_lock(fd, &key);
-#else
-    return fclose(fp);
#endif
+    return fclose(fp);
}

/* Compare a file_lock(lhs) to the file_key(rhs)
_______________________________________________
Devel mailing list
Devel@mbuni.org
http://lists.mbuni.org/mailman/listinfo/devel



_______________________________________________
Devel mailing list
Devel@mbuni.org
http://lists.mbuni.org/mailman/listinfo/devel

Reply via email to