Joe Eykholt wrote: >> This is one way to fix. I would prefer to add a line in >> fcoe_transport_function as ".get_host_port_id = fc_get_host_port_id," >> This is a one line change and also can keep the rest of code free from >> this attribute call. >> > > Eliminating the function is a good idea. Eliminating the field > probably doesn't matter. In the grand scheme of things, anything > that works is fine. >
If we eliminate these libfc fc_get_host* functions then we should also eliminate corresponding field in libfc(e.g lport->fid) and then instead just use single field instance from fc_host_attrs. If we continue maintaining field/s in libfc then we always have to ensure both copies(libfc & fc_host_attr) are up to date without these libfc fc_get_host* functions. So I think eliminating both (fc_get_host* and field in libfc) will be better or just keep using fc_get_host* functions. _______________________________________________ devel mailing list [email protected] http://www.open-fcoe.org/mailman/listinfo/devel
