On Wed, 2009-01-28 at 12:49 -0800, Robert Love wrote: > Signed-off-by: Robert Love <[email protected]> > --- > > drivers/scsi/libfc/fc_disc.c | 10 ++-- > drivers/scsi/libfc/fc_fcp.c | 14 ++--- > drivers/scsi/libfc/fc_lport.c | 2 - > drivers/scsi/libfc/fc_rport.c | 117 > ++++++++++++++++++++++++++++------------- > 4 files changed, 95 insertions(+), 48 deletions(-) >
I don't like this patch anymore. It makes sense to use the macro when setting dd_data to the private data, but it doesn't when accessing that structure. Once we've set that dd_data member, there's no problem with using it. I think that the only way this patch would work was if it removed the dd_data member and only used the macro everwhere, but I don't really see a big benefit in that. _______________________________________________ devel mailing list [email protected] http://www.open-fcoe.org/mailman/listinfo/devel
