On Fri, 2009-09-04 at 16:05 -0700, Joe Eykholt wrote: > Robert Love wrote: > > From: Rob Love <robert.w.l...@intel.com> > > > > Ensures that there are kernel-doc style comments for all > > routines and structures. > > > > There were also a few instances of fc_lport's named 'lp' > > which were switched to 'lport' as per the libfc/libfcoe/fcoe > > naming convention. > > BTW, fnic is not planning to change to this convention quite yet at least. > > > Also, emacs 'indent-region' and 'tabify' were ran on libfcoe.c. > > > > Signed-off-by: Robert Love <robert.w.l...@intel.com> > > --- > > > > drivers/scsi/fcoe/libfcoe.c | 218 > > ++++++++++++++++++++++--------------------- > > include/scsi/libfcoe.h | 83 ++++++++-------- > > 2 files changed, 154 insertions(+), 147 deletions(-) > > > > diff --git a/drivers/scsi/fcoe/libfcoe.c b/drivers/scsi/fcoe/libfcoe.c > > index 3571ba0..9cdab5d 100644 > > --- a/drivers/scsi/fcoe/libfcoe.c > > +++ b/drivers/scsi/fcoe/libfcoe.c > > @@ -1,5 +1,5 @@ > > /* > > - * Copyright (c) 2008-2009 Cisco Systems, Inc. All rights reserved. > > + * Copyright (c) 2008-2009 Cisco Systems, Inc. All rights reserved. > > Why that change? I think double space after . is better than tab, even if it > ends at a tabbed column. > I wouldn't run tabify. It's making unnecessary changes. > Yes, you're right. I'll fix it and the other two comments below. I expect that this copyright problem is in all of the cleanup patches, so I'll double check those too.
_______________________________________________ devel mailing list devel@open-fcoe.org http://www.open-fcoe.org/mailman/listinfo/devel
