Hi Andrew, I currently have another patch to apply which fix OC build against latest Samba4 revision. Jelmer introduced a global loadparm context which is now the first argument of any lp_ functions.
e.g.: lp_parm_string(global_loadparm, NULL, "mapi", "body");
I anyway have a couple of changes to provide/discuss with Jelmer before
I can apply the patch:
1. Some PIDL changes: gen_ndr/misc.h reference in
Samba4/Header.pm has been removed, but is still mandatory for OC
generated IDL files.
2. util/attr.h needs to be added to the make install header list
3. lp_load now take a char * pointing to a valid smb.conf file.
I'd like the filename to be optional but still initialize the
loadparm structure. OC shouldn't be required to rely on
smb.conf.
4. global_loadparm and libmapiadmin. I've maybe missed smth, but
it seems like recent modifications doesn't fix the libmapiadmin
charset related issue.
I'll anyway have a look at the NULL -> 0 which I may have been missing.
See comments in text below:
On Mon, 2007-10-01 at 15:15 +0200, Andrew Gaylard wrote:
> Hi,
>
> This patch fixes all the warnings when building current the SVN
> tree against samba-4.0.0alpha1:
>
> warning: passing argument 1 of 'lp_parm_string' makes integer from
> pointer without a cast
> warning: passing argument 1 of 'lp_parm_int' makes integer from
> pointer without a cast
>
> None of these warnings was particularly dangerous, and the fixes
> are obvious. OK to apply?
See top posting.
> Is there a reason that we tell the Makefile to suppress output?
No reason but development convenience.
> Is there a simple way to turn on the displaying of output?
> I currently use:
> sed -i 's/^\t@/\t/' Makefile.in
>
> to get any warnings to be displayed.
We should normally have warnings displayed -- we are compiling with
-Wall -Wmissing-prototypes -Wstrict-prototypes -- but I may add -Werror
when we are about to release code.
> Andrew
>
> PS: This patch does not fix any of the IDL warnings:
PIDL warnings have been discussing during the CIFS workshop. subcontext
warnings were initially introduced to prepare developers to migrate from
subcontext to represent_as/transmit_as. However, Jelmer got really busy
on other stuff and didn't have time to finish the implementation yet.
The question is now whether we keep subcontext and remove compilation
warnings or finish the implementation and switch from subcontext to
represent_as/transmit_as.
For top-level pointers warnings, this is yet another story.
Cheers,
Julien.
--
Julien Kerihuel
[EMAIL PROTECTED]
OpenChange Project Manager
GPG Fingerprint: 0B55 783D A781 6329 108A B609 7EF6 FE11 A35F 1F79
signature.asc
Description: This is a digitally signed message part
_______________________________________________ devel mailing list [email protected] http://mailman.openchange.org/listinfo/devel
