Hello,
On 07/17/06 11:41, Juha Heinanen wrote:
i started implementing allow_uri function and read how avpops module
parses pseudo variables. in avpops.c fixup_write_avp function i noticed
that presence of domain or username suffix is stored in local flags
variable, but it is not used anywhere. should flags variable be xored
to flags given as argument to avpops_parse_pvar:
ap = avpops_parse_pvar(s, XL_THROW_ERROR|XL_DISABLE_COLORS);
yes, indeed, the flags are not used. Initially they were scheduled for
remove, because the old parameters that could be used with
username/domain flags are replaced by pseudo-variables ($ruri/domain =>
$rd). However, they were kept and intended to be extended as for
avp_db_load() where you can use username/domain flags even for string
values or any other pseudo-variable. But seems that propagation of the
flags was forgotten. I will fix on cvs.
Cheers,
Daniel
-- juha
_______________________________________________
Devel mailing list
[email protected]
http://openser.org/cgi-bin/mailman/listinfo/devel
_______________________________________________
Devel mailing list
[email protected]
http://openser.org/cgi-bin/mailman/listinfo/devel
