Bugs item #1721048, was opened at 2007-05-17 16:34 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743020&aid=1721048&group_id=139143
Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: modules Group: ver 1.2.x Status: Open Resolution: None Priority: 5 Private: No Submitted By: Kobi Eshun (ekobi) Assigned to: Nobody/Anonymous (nobody) Summary: pres. module attempts to read (almost) entire watchers table Initial Comment: Hi, The 'msg_watchers_clean()' function queries the 'watchers' table for subscriptions older than 24 hours that are still pending and then, if there are any, deletes them. Two issues: 1 - why bother with the first query at all -- why not just the issue the delete and let the back-end database deal with a possible empty set? 2 - the pa_dbf.query() for this omits the second clause in the query, so that *all* subscriptions older than 24 hours are retrieved. This table gets huge, and so after a while, this function fails to allocate enough memory to complete the query. The attached trivial patch fixes the problem. -- kobi ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743020&aid=1721048&group_id=139143 _______________________________________________ Devel mailing list [email protected] http://openser.org/cgi-bin/mailman/listinfo/devel
