Bugs item #1752168, was opened at 2007-07-11 21:28 Message generated for change (Comment added) made by agranig You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743020&aid=1752168&group_id=139143
Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: modules Group: ver 1.2.x Status: Open Resolution: None Priority: 5 Private: No Submitted By: Andreas Granig (agranig) Assigned to: Nobody/Anonymous (nobody) Summary: lcr does not work with dbtext Initial Comment: Hi, LCR module checks for DB_STRING type of the gw_addr column in the gw table, but the dbtext backend returns DB_STR. Attached you can find a quick fix for 1.2.x. (I guess HEAD branch has this problem too). Please review, improve and apply. Andreas ---------------------------------------------------------------------- >Comment By: Andreas Granig (agranig) Date: 2007-07-14 14:24 Message: Logged In: YES user_id=825350 Originator: YES I basically agree that the better solution is to change dbtext, but in this case something in LCR changed between 1.1.x and 1.2.x which made it break in combination with dbtext. So for me it's perfectly valid to work around this dbtext limitation so 1.2.x can be used in this scenario, until dbtext is enhanced to also return STRING. ---------------------------------------------------------------------- Comment By: Nobody/Anonymous (nobody) Date: 2007-07-14 11:43 Message: Logged In: NO your patch makes lcr module to accept both STRING and STR results for ip address, because as you say dbtext returns str rather than string result. in my opinion better solution would be to make dbtext module return string result, because then the code would not need to be duplicated in each module that uses string database values. -- juha ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743020&aid=1752168&group_id=139143 _______________________________________________ Devel mailing list [email protected] http://openser.org/cgi-bin/mailman/listinfo/devel
