Patrick McHardy wrote: > Pavel Emelianov wrote: >> Patrick McHardy wrote: >> >>> The question is how to proceed. I haven't read all mails yet, but it >>> seems there is some disagreement about whether to create all devices >>> in the same namespace and move them later or create them directly in >> >> The agreement was that we can make any of the above. We can create >> booth devices in the init namespace and then move one of them into the >> desired namespace, or we can explicitly specify which namespace to create >> the pair in. > > > I'm going to push my latest patches to Dave today, the easiest way is > probably is you just add whatever you need to the API afterwards. > >
OK. Dave didn't object against the driver. Hope he will accept it as well. I have also found a BUG in your API. Look, when you declare the alias with the MODULE_ALIAS_RTNL_LINK in drivers you use strings as an argument. But this macro stringifyes the argument itself which results in bad aliases. Signed-off-by: Pavel Emelianov <[EMAIL PROTECTED]> --- diff --git a/include/net/rtnetlink.h b/include/net/rtnetlink.h index d744198..f627e1f 100644 --- a/include/net/rtnetlink.h +++ b/include/net/rtnetlink.h @@ -77,6 +77,6 @@ extern void __rtnl_link_unregister(struc extern int rtnl_link_register(struct rtnl_link_ops *ops); extern void rtnl_link_unregister(struct rtnl_link_ops *ops); -#define MODULE_ALIAS_RTNL_LINK(name) MODULE_ALIAS("rtnl-link-" #name) +#define MODULE_ALIAS_RTNL_LINK(name) MODULE_ALIAS("rtnl-link-" name) #endif _______________________________________________ Containers mailing list [EMAIL PROTECTED] https://lists.linux-foundation.org/mailman/listinfo/containers _______________________________________________ Devel mailing list Devel@openvz.org https://openvz.org/mailman/listinfo/devel