On Tue, Sep 09, 2008 at 09:20:42AM +0200, Patrick McHardy wrote: > Alexey Dobriyan wrote: >> Add checks for init_net to not create kmem caches twice and so on. >> >> Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> >> >> diff --git a/net/netfilter/nf_conntrack_core.c >> b/net/netfilter/nf_conntrack_core.c >> index b55944e..52d0663 100644 >> --- a/net/netfilter/nf_conntrack_core.c >> +++ b/net/netfilter/nf_conntrack_core.c >> @@ -1016,7 +1016,8 @@ EXPORT_SYMBOL_GPL(nf_conntrack_flush); >> supposed to kill the mall. */ >> void nf_conntrack_cleanup(struct net *net) >> { >> - rcu_assign_pointer(ip_ct_attach, NULL); >> + if (net_eq(net, &init_net)) >> + rcu_assign_pointer(ip_ct_attach, NULL); > > Having multiple of these net_eq checks per function (14 total) is > not a very nice way to do this.
Yep, I was just afraid of some subtle ordering rules and to keep potential init_net breakage to minimum. > How about splitting the code into a netns and a global part instead? Prebably they aren't strict at all. _______________________________________________ Containers mailing list [EMAIL PROTECTED] https://lists.linux-foundation.org/mailman/listinfo/containers _______________________________________________ Devel mailing list Devel@openvz.org https://openvz.org/mailman/listinfo/devel