* Jesper Juhl <j...@chaosbits.net> [2010-11-01 20:40:56]:

> Hi (please CC me on replies),
> 
> 
> Apologies to those who receive this multiple times. I screwed up the To: 
> field in my original mail :-(
> 
> 
> In mem_cgroup_alloc() we currently do either kmalloc() or vmalloc() then 
> followed by memset() to zero the memory. This can be more efficiently 
> achieved by using kzalloc() and vzalloc().
> 
> 
> Signed-off-by: Jesper Juhl <j...@chaosbits.net>
> ---
>  memcontrol.c |    5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/mm/memcontrol.c b/mm/memcontrol.c
> index 9a99cfa..90da698 100644
> --- a/mm/memcontrol.c
> +++ b/mm/memcontrol.c
> @@ -4199,14 +4199,13 @@ static struct mem_cgroup *mem_cgroup_alloc(void)
> 
>       /* Can be very big if MAX_NUMNODES is very big */
>       if (size < PAGE_SIZE)
> -             mem = kmalloc(size, GFP_KERNEL);
> +             mem = kzalloc(size, GFP_KERNEL);
>       else
> -             mem = vmalloc(size);
> +             mem = vzalloc(size);
> 
>       if (!mem)
>               return NULL;
> 
> -     memset(mem, 0, size);
>       mem->stat = alloc_percpu(struct mem_cgroup_stat_cpu);
>       if (!mem->stat) {
>               if (size < PAGE_SIZE)
>

 
Acked-by: Balbir Singh <bal...@linux.vnet.ibm.com>
 

-- 
        Three Cheers,
        Balbir
_______________________________________________
Containers mailing list
contain...@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers

_______________________________________________
Devel mailing list
Devel@openvz.org
https://openvz.org/mailman/listinfo/devel

Reply via email to