Tejun Heo wrote:
> On Sun, Dec 11, 2011 at 03:45:37PM +0100, Glauber Costa wrote:
>> There is no reason to have a flags field, and then a separate
>> bool field just to indicate if the clone_children flag is set.
>> Make it a flag
>>
>> Signed-off-by: Glauber Costa <glom...@parallels.com>
>
> Doesn't this change how remount conditions are checked?
>
Right. Currently we can do this:
# mount -t cgroup xxx /mnt
# mount -o remount,clone_children /mnt
with this patch, the above remount will fail.
But..the current bevaiour of remount is a bit confusing in that remount
with/without "clone_children" has no effect on anything:
# mount -t cgroup -o clone_children xxx /mnt
# cat /mnt/cgroup.clone_children
1
# mount -o remount xxx /mnt
# mount | grep cgroup
xxx on /mnt type cgroup (rw,clone_children)
# cat /mnt/cgroup.clone_children
1
_______________________________________________
Devel mailing list
Devel@openvz.org
https://openvz.org/mailman/listinfo/devel
