Maxim Patlasov <mpatla...@virtuozzo.com> writes: > The series firstly fixes a few issues in handling > barriers in ordinary requests (what was overlooked > in previous patch -- see commit c2247f3745). > > Then there are a few minor rework w/o functional > changes that alleviate main patches (last two ones). > > And finally the series fixes handling barriers > for RELOC_A|S requests. > > The main complexity comes from the following bug: > for direct_io it's not enough to send FUA to flush > all nullified cluster block. See details in > "fix barriers for PLOOP_E_RELOC_NULLIFY" patch. > Ok. Max I can not fully agree the way you orginize fix for RELOC bug (especially for kaio). But it does all major things 1) Removes _FORCE_XXX crap 2) Cleanup barrier stuff 3) Fix RELOC_XXX code flow.
Let's keep style things aside for now, and commit that fix. So ACK whole series. And let optimize/fix sylistic stuff leter. > --- > > Dmitry Monakhov (3): > ploop: deadcode cleanup > ploop: minor rework of ->write_page() io method > ploop: generalize issue_flush > > Maxim Patlasov (6): > ploop: minor rework of ploop_req_delay_fua_possible > ploop: resurrect delayed_fua for io_kaio > ploop: resurrect delay_fua for io_direct > ploop: remove preflush from dio_submit > ploop: fix barriers for PLOOP_E_RELOC_NULLIFY > ploop: fixup barrier handling during relocation > > > drivers/block/ploop/dev.c | 16 ++++++++++-- > drivers/block/ploop/io_direct.c | 48 ++++++++----------------------------- > drivers/block/ploop/io_kaio.c | 26 ++++++++++---------- > drivers/block/ploop/map.c | 50 > ++++++++++++++++++++++++--------------- > include/linux/ploop/ploop.h | 20 +++------------- > 5 files changed, 71 insertions(+), 89 deletions(-) > > -- > Signature
signature.asc
Description: PGP signature
_______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel