This reverts commit 816dbcd6b298343b6b56ef07429bc9c72f69ee67.
We reported this problem to mainstream long ago and there was a commit
7c3b00e06d731 ("ptrace: make wait_on_bit(JOBCTL_TRAPPING_BIT) in
ptrace_attach() killable") which should fix it. So we can revert our
version.
Another reason I want to revert it is that threating ptraced processes
as not needing to freeze may potentially messup with freezer cgroup
frozen status reporting (task count vs frozen task count).
Moreover, in CRIU and vzctl we always wait for cgroup to report frozen
before continuing, so it's highly unlikely that we will do "ptrace on
yet freezing task".
So I guess we are safe to revert this patch.
https://virtuozzo.atlassian.net/browse/PSBM-40683
https://virtuozzo.atlassian.net/browse/VSTOR-118578
Signed-off-by: Pavel Tikhomirov <[email protected]>
Feature: cgroup/freeze: improvements
---
kernel/freezer.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/kernel/freezer.c b/kernel/freezer.c
index 622892a930274..6a96149aede9f 100644
--- a/kernel/freezer.c
+++ b/kernel/freezer.c
@@ -43,9 +43,6 @@ bool freezing_slow_path(struct task_struct *p)
if (test_tsk_thread_flag(p, TIF_MEMDIE))
return false;
- if (p->jobctl & JOBCTL_TRAPPING)
- return false;
-
if (pm_nosig_freezing || cgroup_freezing(p))
return true;
--
2.51.1
_______________________________________________
Devel mailing list
[email protected]
https://lists.openvz.org/mailman/listinfo/devel
