Comment to DEFINE_FREE() explicitly encourages us to include NULL test
in the DEFINE_FREE() statement even when its callback already has a NULL
check inside it. That allows compiler simplify resulting code by
compiling out the cleanup path in case it's not required.
Fixes: 9505e1b00c3f ("ve: Add put_ve() cleanup helper")
https://virtuozzo.atlassian.net/browse/VSTOR-118289
Signed-off-by: Pavel Tikhomirov <[email protected]>
Feature: ve: ve generic structures
---
include/linux/ve.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/ve.h b/include/linux/ve.h
index f66474004100..0fbc4c45525f 100644
--- a/include/linux/ve.h
+++ b/include/linux/ve.h
@@ -323,6 +323,6 @@ static inline int ve_get_cpu_avenrun(struct ve_struct *ve,
unsigned long *avenru
static inline int ve_get_cpu_stat(struct ve_struct *ve, struct kernel_cpustat
*kstat) { return -ENOSYS; }
#endif
-DEFINE_FREE(put_ve, struct ve_struct *, put_ve(_T))
+DEFINE_FREE(put_ve, struct ve_struct *, if (_T) put_ve(_T))
#endif /* _LINUX_VE_H */
--
2.51.1
_______________________________________________
Devel mailing list
[email protected]
https://lists.openvz.org/mailman/listinfo/devel
