> From: Denis V. Lunev <[email protected]> > > ploop_allocator() tests prealloc_size and only then sets itself > TASK_INTERRUPTIBLE before schedule(). A request that lands between the > two finds the thread still running, so wake_up_process() does nothing, > and the thread goes to sleep with the request pending. A pio whose > cluster is past the end of the top delta then waits in > ploop_allocate_cluster() for good: ploop_req_prealloc() does not wake > the thread for a size already requested, so later requests do not end > the stall either. The dispatcher waits for every runner to go idle > before it hands out more work, so the whole device stalls. > > The thread tests kthread_should_stop() before setting the task state > too, so a kthread_stop() is lost the same way and the removal of the > device hangs. > > Set the task state before testing prealloc_size and > kthread_should_stop(). > > Fixes: cf489cf22cd5 ("dm-ploop: make filespace preallocations async") > Reported-by: Konstantin Khorenko <[email protected]> > https://virtuozzo.atlassian.net/browse/VSTOR-152984 > Feature: dm-ploop: ploop target driver > Reviewed-by: Andrey Zhadchenko <[email protected]> > Reviewed-by: Konstantin Khorenko <[email protected]> > Signed-off-by: Denis V. Lunev <[email protected]>
Sashiko has reviewed this patch and found no issues. It looks great! -- Sashiko AI review ยท https://sashiko.vzint.dev/#/patchset/[email protected]?part=2 _______________________________________________ Devel mailing list [email protected] https://lists.openvz.org/mailman/listinfo/devel
