> pb_timer_func() checks pb->deadline_jiffies every time it fires and > re-arms itself under pb->lock while requests are delayed, and > postpone_if_required_for_backup() arms it under pb->lock when the first > request is delayed. So the timer is always pending while writes are > delayed and we don't need to re-arm it after updating the field. > > This call is also not done under pb->lock. Today it is harmless because > write and stop are serialized by pb->ctl_rwsem, but it would re-arm the > timer behind timer_delete_sync() in push_backup_stop() once the write > path is reachable without the rwsem (next patch). > > https://virtuozzo.atlassian.net/browse/VSTOR-152912 > Signed-off-by: Andrey Zhadchenko <[email protected]>
Sashiko has reviewed this patch and found no issues. It looks great! -- Sashiko AI review ยท https://sashiko.vzint.dev/#/patchset/[email protected]?part=6 _______________________________________________ Devel mailing list [email protected] https://lists.openvz.org/mailman/listinfo/devel
